Remove phpstan errors from integration API tests

[MAILPOET-3235]

tests/integration/API/JSON/v1/AutomatedLatestContentTest.php

@@ -22,6 +22,7 @@ class AutomatedLatestContentTest extends \MailPoetTest {
     // WP's default post type 'revision' is excluded from search
     // https://codex.wordpress.org/Post_Types
     $revisionPostType = get_post_type_object('revision');
+    assert($revisionPostType instanceof \WP_Post_Type);
     expect($revisionPostType->exclude_from_search)->true(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps
     expect(isset($response->data['revision']))->false();
   }

tests/integration/API/JSON/v1/CustomFieldsTest.php

@@ -7,6 +7,7 @@ use MailPoet\API\JSON\ResponseBuilders\CustomFieldsResponseBuilder;
 use MailPoet\API\JSON\v1\CustomFields;
 use MailPoet\CustomFields\CustomFieldsRepository;
 use MailPoet\DI\ContainerWrapper;
+use MailPoet\Entities\CustomFieldEntity;
 use MailPoet\Models\CustomField;
 
 class CustomFieldsTest extends \MailPoetTest {
@@ -83,6 +84,7 @@ class CustomFieldsTest extends \MailPoetTest {
 
   public function testItCanDeleteACustomField() {
     $customField = CustomField::where('type', 'date')->findOne();
+    assert($customField instanceof CustomField);
     $customFieldId = $customField->id();
 
     $router = new CustomFields($this->repository, new CustomFieldsResponseBuilder());
@@ -122,6 +124,7 @@ class CustomFieldsTest extends \MailPoetTest {
 
   public function testItCanGetACustomField() {
     $customField = $this->repository->findOneBy(['name' => 'CF: text']);
+    assert($customField instanceof CustomFieldEntity);
 
     $router = new CustomFields($this->repository, new CustomFieldsResponseBuilder());
     $response = $router->get(['id' => $customField->getId()]);

tests/integration/API/JSON/v1/DynamicSegmentsTest.php

@@ -147,6 +147,7 @@ class DynamicSegmentsTest extends \MailPoetTest {
     expect($response->meta['count'])->equals(1);
 
     $dynamicSegment = DynamicSegment::findOne($dynamicSegment->id);
+    assert($dynamicSegment instanceof DynamicSegment);
     expect($dynamicSegment->deletedAt)->notNull();
 
     $dynamicSegment->delete();
@@ -172,6 +173,7 @@ class DynamicSegmentsTest extends \MailPoetTest {
     expect($response->meta['count'])->equals(1);
 
     $dynamicSegment = DynamicSegment::findOne($dynamicSegment->id);
+    assert($dynamicSegment instanceof DynamicSegment);
     expect($dynamicSegment->deletedAt)->equals(null);
 
     $dynamicSegment->delete();

tests/integration/API/JSON/v1/FormsTest.php

@@ -167,6 +167,7 @@ class FormsTest extends \MailPoetTest {
     $this->form1->trash();
 
     $trashedForm = Form::findOne($this->form1->id);
+    assert($trashedForm instanceof Form);
     expect($trashedForm->deletedAt)->notNull();
 
     $response = $this->endpoint->restore(['id' => $this->form1->id]);

tests/integration/API/JSON/v1/ImportExportTest.php

@@ -24,6 +24,7 @@ class ImportExportTest extends \MailPoetTest {
     $response = $this->endpoint->setupWooCommerceInitialImport();
     expect($response->status)->equals(200);
     $task = ScheduledTask::where('type', WooCommerceSync::TASK_TYPE)->findOne();
+    assert($task instanceof ScheduledTask);
     expect($task->status)->equals(ScheduledTask::STATUS_SCHEDULED);
     $now = time();
     $scheduledAt = new Carbon($task->scheduledAt);
@@ -36,6 +37,7 @@ class ImportExportTest extends \MailPoetTest {
     $this->createTask(WooCommerceSync::TASK_TYPE, ScheduledTask::STATUS_SCHEDULED, $originalSchedule);
     $this->endpoint->setupWooCommerceInitialImport();
     $task = ScheduledTask::where('type', WooCommerceSync::TASK_TYPE)->findOne();
+    assert($task instanceof ScheduledTask);
     expect($task->status)->equals(ScheduledTask::STATUS_SCHEDULED);
     $now = time();
     $scheduledAt = new Carbon($task->scheduledAt);
@@ -49,6 +51,7 @@ class ImportExportTest extends \MailPoetTest {
     $this->createTask(WooCommerceSync::TASK_TYPE, null);
     $this->endpoint->setupWooCommerceInitialImport();
     $task = ScheduledTask::where('type', WooCommerceSync::TASK_TYPE)->findOne();
+    assert($task instanceof ScheduledTask);
     expect($task->status)->equals(null);
     $taskCount = ScheduledTask::where('type', WooCommerceSync::TASK_TYPE)->count();
     expect($taskCount)->equals(1);

tests/integration/API/JSON/v1/SendingQueueTest.php

@@ -54,6 +54,7 @@ class SendingQueueTest extends \MailPoetTest {
     $sendingQueue = $this->diContainer->get(SendingQueueAPI::class);
     $result = $sendingQueue->add(['newsletter_id' => $newsletter->id]);
     $scheduledTask = ScheduledTask::findOne($result->data['task_id']);
+    assert($scheduledTask instanceof ScheduledTask);
     expect($scheduledTask->status)->equals(ScheduledTask::STATUS_SCHEDULED);
     expect($scheduledTask->scheduledAt)->equals($newletterOptions['scheduledAt']);
     expect($scheduledTask->type)->equals(Sending::TASK_TYPE);
@@ -90,6 +91,7 @@ class SendingQueueTest extends \MailPoetTest {
     // add scheduled task
     $result = $sendingQueue->add(['newsletter_id' => $newsletter->id]);
     $scheduledTask = ScheduledTask::findOne($result->data['task_id']);
+    assert($scheduledTask instanceof ScheduledTask);
     expect($scheduledTask->scheduledAt)->equals('2018-10-10 10:00:00');
 
     // update scheduled time
@@ -103,6 +105,7 @@ class SendingQueueTest extends \MailPoetTest {
     );
     $result = $sendingQueue->add(['newsletter_id' => $newsletter->id]);
     $rescheduledTask = ScheduledTask::findOne($result->data['task_id']);
+    assert($rescheduledTask instanceof ScheduledTask);
     // new task was not created
     expect($rescheduledTask->id)->equals($scheduledTask->id);
     // scheduled time was updated

tests/integration/API/JSON/v1/SendingTaskSubscribersTest.php

@@ -199,14 +199,17 @@ class SendingTaskSubscribersTest extends \MailPoetTest {
     $taskSubscriber = ScheduledTaskSubscriber::where('task_id', $this->taskId)
       ->where('subscriber_id', $this->failedSubscriber->id)
       ->findOne();
+    assert($taskSubscriber instanceof ScheduledTaskSubscriber);
     expect($taskSubscriber->error)->equals('');
     expect($taskSubscriber->failed)->equals(0);
     expect($taskSubscriber->processed)->equals(0);
 
     $task = ScheduledTask::findOne($this->taskId);
+    assert($task instanceof ScheduledTask);
     expect($task->status)->equals(null);
 
     $newsletter = Newsletter::findOne($this->newsletterId);
+    assert($newsletter instanceof Newsletter);
     expect($newsletter->status)->equals(Newsletter::STATUS_SENDING);
   }
 

tests/integration/API/JSON/v1/SettingsTest.php

@@ -139,6 +139,7 @@ class SettingsTest extends \MailPoetTest {
     $task = ScheduledTask::where('type', InactiveSubscribers::TASK_TYPE)
       ->whereRaw('status = ?', [ScheduledTask::STATUS_SCHEDULED])
       ->findOne();
+    assert($task instanceof ScheduledTask);
     expect($task->scheduledAt)->lessThan(Carbon::now());
   }