Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix types by casting [MAILPOET-2488]

Browse Source
This commit is contained in:
wxa
2019-12-26 18:03:32 +03:00
committed by amine-mp
parent c493a43c35
commit bd1a84c5c3
25 changed files with 41 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/integration/API/JSON/v1/NewslettersTest.php
View File

@@ -974,7 +974,7 @@ class NewslettersTest extends \MailPoetTest {
public function testItGeneratesPreviewLinksWithNewsletterHashAndNoSubscriberData() {
$response = $this->endpoint->listing();
$preview_link = $response->data[0]['preview_url'];
parse_str(parse_url($preview_link, PHP_URL_QUERY), $preview_link_data);
parse_str((string)parse_url($preview_link, PHP_URL_QUERY), $preview_link_data);
$preview_link_data = Url::transformUrlDataObject(Router::decodeRequestData($preview_link_data['data']));
expect($preview_link_data['newsletter_hash'])->notEmpty();
expect($preview_link_data['subscriber_id'])->false();

2
tests/integration/API/JSON/v1/SendingQueueTest.php
View File

@@ -122,7 +122,7 @@ class SendingQueueTest extends \MailPoetTest {
->findOne();
if (!$newsletter_option) {
$newsletter_option = NewsletterOption::create();
$newsletter_option->option_field_id = $newsletter_option_field->id;
$newsletter_option->option_field_id = (int)$newsletter_option_field->id;
$newsletter_option->newsletter_id = $newsletter_id;
}
$newsletter_option->value = $value;

2
tests/integration/API/JSON/v1/SubscribersTest.php
View File

@@ -805,7 +805,7 @@ class SubscribersTest extends \MailPoetTest {
expect($newsletter_option_field->getErrors())->false();
$newsletter_option = NewsletterOption::create();
$newsletter_option->option_field_id = $newsletter_option_field->id;
$newsletter_option->option_field_id = (int)$newsletter_option_field->id;
$newsletter_option->newsletter_id = $welcome_newsletter->id;
$newsletter_option->value = $value;
$newsletter_option->save();