Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Replace expect()->lessOrEquals() with verify()->lessThanOrEqual()

Browse Source 
codeception/verify 2.1 removed support for expect()->lessOrEquals() so we need
to replace it with verify()->lessThanOrEqual().

[MAILPOET-5664]
This commit is contained in:
Rodrigo Primo
2023-10-18 16:54:16 -03:00
committed by David Remer
parent e4f0b89032
commit c1c59fe392
5 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mailpoet/tests/integration/API/JSON/v1/ImportExportTest.php
View File

@@ -39,7 +39,7 @@ class ImportExportTest extends \MailPoetTest {
$now = time();
$scheduledAt = new Carbon($task->getScheduledAt());
expect($scheduledAt->timestamp)->greaterOrEquals($now - 1);
expect($scheduledAt->timestamp)->lessOrEquals($now + 1);
verify($scheduledAt->timestamp)->lessThanOrEqual($now + 1);
}
public function testItReschedulesScheduledTaskToNow() {
@@ -53,7 +53,7 @@ class ImportExportTest extends \MailPoetTest {
$now = time();
$scheduledAt = new Carbon($task->getScheduledAt());
expect($scheduledAt->timestamp)->greaterOrEquals($now - 1);
expect($scheduledAt->timestamp)->lessOrEquals($now + 1);
verify($scheduledAt->timestamp)->lessThanOrEqual($now + 1);
$taskCount = $this->scheduledTasksRepository->countBy(['type' => WooCommerceSync::TASK_TYPE]);
verify($taskCount)->equals(1);
}

2
mailpoet/tests/integration/Cron/Workers/KeyCheck/KeyCheckWorkerTest.php
View File

@@ -103,7 +103,7 @@ class KeyCheckWorkerTest extends \MailPoetTest {
$secondsToMidnight = $dateTime->diffInSeconds($dateTime->copy()->startOfDay()->addDay());
// next run should be planned in 6 hours after midnight
expect($nextRunDate->diffInSeconds($dateTime))->lessOrEquals(21600 + $secondsToMidnight);
verify($nextRunDate->diffInSeconds($dateTime))->lessThanOrEqual(21600 + $secondsToMidnight);
}
private function createRunningTask(Carbon $scheduledAt = null) {

2
mailpoet/tests/integration/Cron/Workers/SimpleWorkerTest.php
View File

@@ -63,7 +63,7 @@ class SimpleWorkerTest extends \MailPoetTest {
$difference = $nextRunDate->diffInDays($currentDate);
// Subtract days left in the current week
$difference -= (Carbon::DAYS_PER_WEEK - (int)$currentDate->format('N'));
expect($difference)->lessOrEquals(7);
verify($difference)->lessThanOrEqual(7);
expect($difference)->greaterOrEquals(0);
}
}

4
mailpoet/tests/integration/Subscription/PagesTest.php
View File

@@ -152,9 +152,9 @@ class PagesTest extends \MailPoetTest {
$this->assertInstanceOf(SubscriberEntity::class, $confirmedSubscriber);
verify($confirmedSubscriber->getStatus())->equals(SubscriberEntity::STATUS_SUBSCRIBED);
expect($confirmedSubscriber->getConfirmedAt())->greaterOrEquals(Carbon::createFromTimestamp($this->wp->currentTime('timestamp'))->subSecond());
expect($confirmedSubscriber->getConfirmedAt())->lessOrEquals(Carbon::createFromTimestamp($this->wp->currentTime('timestamp'))->addSecond());
verify($confirmedSubscriber->getConfirmedAt())->lessThanOrEqual(Carbon::createFromTimestamp($this->wp->currentTime('timestamp'))->addSecond());
expect($confirmedSubscriber->getLastSubscribedAt())->greaterOrEquals(Carbon::createFromTimestamp($this->wp->currentTime('timestamp'))->subSecond());
expect($confirmedSubscriber->getLastSubscribedAt())->lessOrEquals(Carbon::createFromTimestamp($this->wp->currentTime('timestamp'))->addSecond());
verify($confirmedSubscriber->getLastSubscribedAt())->lessThanOrEqual(Carbon::createFromTimestamp($this->wp->currentTime('timestamp'))->addSecond());
verify($confirmedSubscriber->getFirstName())->equals('First name');
}

2
mailpoet/tests/integration/Tasks/Subscribers/BatchIteratorTest.php
View File

@@ -57,7 +57,7 @@ class BatchIteratorTest extends \MailPoetTest {
if ($i < $iterations) {
verify(count($batch))->equals($this->batchSize);
} else {
expect(count($batch))->lessOrEquals($this->batchSize);
verify(count($batch))->lessThanOrEqual($this->batchSize);
}
}
verify($i)->equals($iterations);