Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove commented out code, raise code similarity trigger treshold

Browse Source
This commit is contained in:
Tautvidas Sipavičius
2016-06-29 21:19:24 +03:00
parent e4dbeca664
commit c396254e64
3 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Config/Analytics.php
View File

@ -10,8 +10,7 @@ class Analytics {
} }
function init() { function init() {
// review: this creates a fatal error when mailpoet tables are dropped. add_action('admin_enqueue_scripts', array($this, 'setupAdminDependencies'));
//add_action('admin_enqueue_scripts', array($this, 'setupAdminDependencies'));
} }
function setupAdminDependencies() { function setupAdminDependencies() {

4
lib/Subscribers/ImportExport/ImportExportFactory.php
View File

@ -34,10 +34,6 @@ class ImportExportFactory {
'last_name' => __('Last name'), 'last_name' => __('Last name'),
'status' => __('Status') 'status' => __('Status')
// TODO: add additional fields from MP2 // TODO: add additional fields from MP2
/*
'confirmed_ip' => __('IP address')
'confirmed_at' => __('Subscription date')
*/
); );
} }

6
tasks/code_sniffer/MailPoet/ruleset.xml
View File

@ -106,7 +106,11 @@
<rule ref="Squiz.ControlStructures.ForLoopDeclaration"/> <rule ref="Squiz.ControlStructures.ForLoopDeclaration"/>
<!-- There should not be commented out code --> <!-- There should not be commented out code -->
<rule ref="Squiz.PHP.CommentedOutCode"/> <rule ref="Squiz.PHP.CommentedOutCode">
<properties>
<property name="maxPercentage" value="50"/>
</properties>
</rule>
<!-- Discourage use of debug functions --> <!-- Discourage use of debug functions -->
<rule ref="Squiz.PHP.DiscouragedFunctions"/> <rule ref="Squiz.PHP.DiscouragedFunctions"/>
<!-- Discourage use of eval --> <!-- Discourage use of eval -->