Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix newly found phpstan errors

Browse Source 
[MAILPOET-3792]
This commit is contained in:
Pavel Dohnal
2021-10-22 09:29:48 +02:00
committed by Veljko V
parent f597416837
commit c4037776f7
5 changed files with 36 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/integration/Statistics/Track/ClicksTest.php
View File

@@ -196,7 +196,9 @@ class ClicksTest extends \MailPoetTest {
$trackedClicks = $clicksRepository->findAll();
expect($trackedClicks)->count(1);
$click = $trackedClicks[0];
expect($click->getUserAgent()->getUserAgent())->equals('User Agent');
$userAgent = $click->getUserAgent();
$this->assertInstanceOf(UserAgentEntity::class, $userAgent);
expect($userAgent->getUserAgent())->equals('User Agent');
}
public function testItUpdateUserAgent(): void {
@@ -219,13 +221,17 @@ class ClicksTest extends \MailPoetTest {
$trackedClicks = $clicksRepository->findAll();
expect($trackedClicks)->count(1);
$click = $trackedClicks[0];
expect($click->getUserAgent()->getUserAgent())->equals('User Agent');
$userAgent = $click->getUserAgent();
$this->assertInstanceOf(UserAgentEntity::class, $userAgent);
expect($userAgent->getUserAgent())->equals('User Agent');
$data->userAgent = 'User Agent 2';
$clicks->track($data);
$trackedClicks = $clicksRepository->findAll();
expect($trackedClicks)->count(1);
$click = $trackedClicks[0];
expect($click->getUserAgent()->getUserAgent())->equals('User Agent 2');
$userAgent = $click->getUserAgent();
$this->assertInstanceOf(UserAgentEntity::class, $userAgent);
expect($userAgent->getUserAgent())->equals('User Agent 2');
}
public function testItDoesNotOverrideHumanUserAgentWithMachine(): void {