Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Enforce heading font size in mobile forms

Browse Source 
[MAILPOET-3024]
This commit is contained in:
Rostislav Wolny
2020-07-07 13:18:50 +02:00
committed by Veljko V
parent a6b8330968
commit c66eae74cd
3 changed files with 16 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
assets/css/src/components-public/_public.scss
View File

@@ -408,3 +408,9 @@ div.mailpoet_form_slide_in.active {
.mailpoet-has-background-color { .mailpoet-has-background-color {
padding: 20px 30px; padding: 20px 30px;
} }
.mailpoet-heading {
@include breakpoint-max-width($form-break-small-width - 1) {
font-size: 18px !important;
}
}

5
lib/Form/Block/Heading.php
View File

@@ -49,7 +49,7 @@ class Heading {
} }
private function renderClass(array $block): string { private function renderClass(array $block): string {
$classes = []; $classes = ['mailpoet-heading'];
if (isset($block['params']['class_name'])) { if (isset($block['params']['class_name'])) {
$classes[] = $block['params']['class_name']; $classes[] = $block['params']['class_name'];
} }
@@ -58,9 +58,6 @@ class Heading {
$classes[] = 'mailpoet-has-background-color'; $classes[] = 'mailpoet-has-background-color';
} }
if (empty($classes)) {
return '';
}
return 'class="' return 'class="'
. join(' ', $classes) . join(' ', $classes)
. '"'; . '"';

18
tests/unit/Form/Block/HeadingTest.php
View File

@@ -24,7 +24,7 @@ class HeadingTest extends \MailPoetUnitTest {
'content' => 'Header', 'content' => 'Header',
], ],
]); ]);
expect($html)->equals('<h2>Header</h2>'); expect($html)->equals('<h2 class="mailpoet-heading">Header</h2>');
} }
public function testItShouldRenderLevel() { public function testItShouldRenderLevel() {
@@ -34,7 +34,7 @@ class HeadingTest extends \MailPoetUnitTest {
'level' => 1, 'level' => 1,
], ],
]); ]);
expect($html)->equals('<h1>Header</h1>'); expect($html)->equals('<h1 class="mailpoet-heading">Header</h1>');
} }
public function testItShouldRenderClass() { public function testItShouldRenderClass() {
@@ -45,7 +45,7 @@ class HeadingTest extends \MailPoetUnitTest {
'class_name' => 'class1 class2', 'class_name' => 'class1 class2',
], ],
]); ]);
expect($html)->equals('<h1 class="class1 class2">Header</h1>'); expect($html)->equals('<h1 class="mailpoet-heading class1 class2">Header</h1>');
} }
public function testItShouldRenderAnchor() { public function testItShouldRenderAnchor() {
@@ -56,7 +56,7 @@ class HeadingTest extends \MailPoetUnitTest {
'anchor' => 'anchor', 'anchor' => 'anchor',
], ],
]); ]);
expect($html)->equals('<h1 id="anchor">Header</h1>'); expect($html)->equals('<h1 class="mailpoet-heading" id="anchor">Header</h1>');
} }
public function testItShouldRenderAlign() { public function testItShouldRenderAlign() {
@@ -67,7 +67,7 @@ class HeadingTest extends \MailPoetUnitTest {
'align' => 'right', 'align' => 'right',
], ],
]); ]);
expect($html)->equals('<h1 style="text-align: right">Header</h1>'); expect($html)->equals('<h1 class="mailpoet-heading" style="text-align: right">Header</h1>');
} }
public function testItShouldRenderTextColour() { public function testItShouldRenderTextColour() {
@@ -78,7 +78,7 @@ class HeadingTest extends \MailPoetUnitTest {
'text_color' => 'red', 'text_color' => 'red',
], ],
]); ]);
expect($html)->equals('<h1 style="color: red">Header</h1>'); expect($html)->equals('<h1 class="mailpoet-heading" style="color: red">Header</h1>');
} }
public function testItShouldRenderBackgroundColor() { public function testItShouldRenderBackgroundColor() {
@@ -89,7 +89,7 @@ class HeadingTest extends \MailPoetUnitTest {
], ],
]); ]);
expect($html)->contains('style="background-color: red'); expect($html)->contains('style="background-color: red');
expect($html)->contains('class="mailpoet-has-background-color"'); expect($html)->contains('class="mailpoet-heading mailpoet-has-background-color"');
} }
public function testItShouldRenderFontSize() { public function testItShouldRenderFontSize() {
@@ -99,7 +99,7 @@ class HeadingTest extends \MailPoetUnitTest {
'font_size' => '33', 'font_size' => '33',
], ],
]); ]);
expect($html)->equals('<h2 style="font-size: 33px">Header</h2>'); expect($html)->equals('<h2 class="mailpoet-heading" style="font-size: 33px">Header</h2>');
} }
public function testItShouldRenderLineHeight() { public function testItShouldRenderLineHeight() {
@@ -109,6 +109,6 @@ class HeadingTest extends \MailPoetUnitTest {
'line_height' => '2.3', 'line_height' => '2.3',
], ],
]); ]);
expect($html)->equals('<h2 style="line-height: 2.3">Header</h2>'); expect($html)->equals('<h2 class="mailpoet-heading" style="line-height: 2.3">Header</h2>');
} }
} }