Refactor getting segments for import into doctrine

[MAILPOET-3164]
This commit is contained in:
Rostislav Wolny
2021-01-19 15:50:23 +01:00
committed by Veljko V
parent 6c7000430d
commit c7152e9448

View File

@ -4,8 +4,10 @@ namespace MailPoet\Subscribers\ImportExport;
use MailPoet\DI\ContainerWrapper; use MailPoet\DI\ContainerWrapper;
use MailPoet\DynamicSegments\FreePluginConnectors\AddToNewslettersSegments; use MailPoet\DynamicSegments\FreePluginConnectors\AddToNewslettersSegments;
use MailPoet\Entities\SegmentEntity;
use MailPoet\Models\CustomField; use MailPoet\Models\CustomField;
use MailPoet\Models\Segment; use MailPoet\Models\Segment;
use MailPoet\Segments\SegmentSubscribersRepository;
use MailPoet\Util\Helpers; use MailPoet\Util\Helpers;
class ImportExportFactory { class ImportExportFactory {
@ -18,14 +20,21 @@ class ImportExportFactory {
/** @var AddToNewslettersSegments */ /** @var AddToNewslettersSegments */
private $addToNewslettersSegments; private $addToNewslettersSegments;
/** @var SegmentSubscribersRepository */
private $segmentSubscribersRepository;
public function __construct($action = null) { public function __construct($action = null) {
$this->action = $action; $this->action = $action;
$this->addToNewslettersSegments = ContainerWrapper::getInstance()->get(AddToNewslettersSegments::class); $this->addToNewslettersSegments = ContainerWrapper::getInstance()->get(AddToNewslettersSegments::class);
$this->segmentSubscribersRepository = ContainerWrapper::getInstance()->get(SegmentSubscribersRepository::class);
} }
public function getSegments() { public function getSegments() {
$segments = $this->segmentSubscribersRepository->getSimpleSegmentListWithSubscribersCounts();
if ($this->action === self::IMPORT_ACTION) { if ($this->action === self::IMPORT_ACTION) {
$segments = Segment::getSegmentsForImport(); $segments = array_values(array_filter($segments, function($segment) {
return in_array($segment['type'], [SegmentEntity::TYPE_DEFAULT, SegmentEntity::TYPE_WP_USERS]);
}));
} else { } else {
$segments = Segment::getSegmentsForExport(); $segments = Segment::getSegmentsForExport();
$segments = $this->addToNewslettersSegments->add($segments); $segments = $this->addToNewslettersSegments->add($segments);