Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Update database entry only when an actual change happend

Browse Source 
[MAILPOET-4430]
This commit is contained in:
David Remer
2022-08-01 09:37:40 +03:00
committed by Veljko V
parent 8432cfa904
commit c7f10a18c4
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
mailpoet/lib/Automation/Engine/Builder/UpdateWorkflowController.php
View File

@ -39,19 +39,20 @@ class UpdateWorkflowController {
} }
$changed = false; $changed = false;
$storedData = $workflow->toArray();
if (array_key_exists('name', $data)) { if (array_key_exists('name', $data) && $workflow->getName() !== $data['name']) {
$workflow->setName($data['name']); $workflow->setName($data['name']);
$changed = true; $changed = true;
} }
if (array_key_exists('status', $data)) { if (array_key_exists('status', $data) && $workflow->getStatus() !== $data['status']) {
$this->checkWorkflowStatus($data['status']); $this->checkWorkflowStatus($data['status']);
$workflow->setStatus($data['status']); $workflow->setStatus($data['status']);
$changed = true; $changed = true;
} }
if (array_key_exists('steps', $data)) { if (array_key_exists('steps', $data) && json_decode($storedData['steps'], true) !== $data['steps']) {
$this->validateWorkflowSteps($workflow, $data['steps']); $this->validateWorkflowSteps($workflow, $data['steps']);
$this->updateStepsController->updateSteps($workflow, $data['steps']); $this->updateStepsController->updateSteps($workflow, $data['steps']);
foreach ($workflow->getSteps() as $step) { foreach ($workflow->getSteps() as $step) {
@ -61,11 +62,13 @@ class UpdateWorkflowController {
$changed = true; $changed = true;
} }
if ($changed) { if (!$changed) {
$this->hooks->doWorkflowBeforeSave($workflow); return $workflow;
$this->storage->updateWorkflow($workflow);
} }
$this->hooks->doWorkflowBeforeSave($workflow);
$this->storage->updateWorkflow($workflow);
$workflow = $this->storage->getWorkflow($id); $workflow = $this->storage->getWorkflow($id);
if (!$workflow) { if (!$workflow) {
throw Exceptions::workflowNotFound($id); throw Exceptions::workflowNotFound($id);