From c8964b88a38fec54c1506581b1b402e88e1abf3d Mon Sep 17 00:00:00 2001
From: Pavel Dohnal <pavel.dohnal@automattic.com>
Date: Fri, 4 Jun 2021 11:21:02 +0200
Subject: [PATCH] Prevent duplication of data in factories

[MAILPOET-3627]
---
 tests/DataFactories/Newsletter.php | 4 ++--
 tests/DataFactories/Subscriber.php | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/DataFactories/Newsletter.php b/tests/DataFactories/Newsletter.php
index 5628ba1b82..0ce880a1c2 100644
--- a/tests/DataFactories/Newsletter.php
+++ b/tests/DataFactories/Newsletter.php
@@ -253,7 +253,7 @@ class Newsletter {
    */
   public function withSegments(array $segments) {
     foreach ($segments as $segment) {
-      $this->segments[] = $segment;
+      $this->segments[$segment->getId()] = $segment;
     }
     return $this;
   }
@@ -279,7 +279,7 @@ class Newsletter {
   }
 
   public function withSubscriber(SubscriberEntity $subscriber, array $data = []) {
-    $this->taskSubscribers[] = array_merge([
+    $this->taskSubscribers[$subscriber->getId()] = array_merge([
       'subscriber' => $subscriber,
       'processed' => 1,
       'failed' => 0,
diff --git a/tests/DataFactories/Subscriber.php b/tests/DataFactories/Subscriber.php
index 3256fd99eb..1453a13e95 100644
--- a/tests/DataFactories/Subscriber.php
+++ b/tests/DataFactories/Subscriber.php
@@ -74,7 +74,9 @@ class Subscriber {
    * @return $this
    */
   public function withSegments(array $segments) {
-    $this->segments = array_merge($this->segments, $segments);
+    foreach ($segments as $segment) {
+      $this->segments[$segment->getId()] = $segment;
+    }
     return $this;
   }