Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Use epxlicit transaction demarcation

Browse Source 
[MAILPOET-5845]
This commit is contained in:
Jan Jakes
2024-01-18 14:07:58 +01:00
committed by Aschepikov
parent 082ab78f90
commit cb803d6f4b
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
mailpoet/lib/Newsletter/NewslettersRepository.php
View File

@@ -32,6 +32,7 @@ use MailPoetVendor\Carbon\Carbon;
use MailPoetVendor\Doctrine\DBAL\Connection; use MailPoetVendor\Doctrine\DBAL\Connection;
use MailPoetVendor\Doctrine\ORM\EntityManager; use MailPoetVendor\Doctrine\ORM\EntityManager;
use MailPoetVendor\Doctrine\ORM\Query\Expr\Join; use MailPoetVendor\Doctrine\ORM\Query\Expr\Join;
use Throwable;
/** /**
* @extends Repository<NewsletterEntity> * @extends Repository<NewsletterEntity>
@@ -404,7 +405,8 @@ class NewslettersRepository extends Repository {
$childrenIds = $this->fetchChildrenIds($ids); $childrenIds = $this->fetchChildrenIds($ids);
$ids = array_merge($ids, $childrenIds); $ids = array_merge($ids, $childrenIds);
$this->entityManager->transactional(function (EntityManager $entityManager) use ($ids) { $this->entityManager->beginTransaction();
try {
// Delete statistics data // Delete statistics data
$this->statisticsNewslettersRepository->deleteByNewsletterIds($ids); $this->statisticsNewslettersRepository->deleteByNewsletterIds($ids);
$this->statisticsOpensRepository->deleteByNewsletterIds($ids); $this->statisticsOpensRepository->deleteByNewsletterIds($ids);
@@ -476,7 +478,12 @@ class NewslettersRepository extends Repository {
$this->detachAll(function (NewsletterEntity $entity) use ($ids) { $this->detachAll(function (NewsletterEntity $entity) use ($ids) {
return in_array($entity->getId(), $ids, true); return in_array($entity->getId(), $ids, true);
}); });
});
$this->entityManager->commit();
} catch (Throwable $e) {
$this->entityManager->rollback();
throw $e;
}
return count($ids); return count($ids);
} }