Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Refactor panel toggle reducer to be more readable

Browse Source 
[MAILPOET-2455]
This commit is contained in:
Rostislav Wolny
2019-11-27 12:38:52 +01:00
committed by Jack Kitterhing
parent a1ac7cb4fd
commit cd0cce07a6
2 changed files with 36 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
assets/js/src/form_editor/store/actions.jsx
View File

@@ -61,11 +61,17 @@ export function switchSidebarTab(id) {
};
}
export function toggleSidebarPanel(id, isOpened = undefined) {
/**
* Toggle a panel within the sidebar. Use toggleTo to enforce certain state
* @param {string} id
* @param {string|undefined} toggleTo - possible values 'opened', 'closed'
* @return {{toggleTo: string|undefined, id: string, type: string}}
*/
export function toggleSidebarPanel(id, toggleTo = undefined) {
return {
type: 'TOGGLE_SIDEBAR_PANEL',
id,
isOpened,
toggleTo,
};
}

35
assets/js/src/form_editor/store/reducers/toggle_sidebar_panel.jsx
View File

@@ -1,13 +1,34 @@
import { remove } from 'lodash';
export default (state, action) => {
const openedPanels = [...state.sidebar.openedPanels];
const isOpenedCurrent = openedPanels.includes(action.id);
const isOpenedFinal = action.isOpened !== undefined ? action.isOpened : !isOpenedCurrent;
if (isOpenedFinal && !isOpenedCurrent) {
openedPanels.push(action.id);
const getRequiredAction = (openedPanels, panelId, toggleTo) => {
const isPanelOpened = openedPanels.includes(panelId);
let requestedToggleState = toggleTo;
if (requestedToggleState === undefined) {
requestedToggleState = isPanelOpened ? 'closed' : 'opened';
}
if (!isOpenedFinal && isOpenedCurrent) {
if (isPanelOpened && requestedToggleState === 'closed') {
return 'close';
}
if (!isPanelOpened && requestedToggleState === 'opened') {
return 'open';
}
return null;
};
/**
* @param {object} state
* @param {{toggleTo: string|undefined, id: string, type: string}} action
* @return {object} Modified state object
*/
export default (state, action) => {
if (action.toggleTo !== undefined && !['opened', 'closed'].includes(action.toggleTo)) {
throw new Error(`Unexpected toggleTo value "${action.toggleTo}"`);
}
const openedPanels = [...state.sidebar.openedPanels];
const requiredAction = getRequiredAction(openedPanels, action.id, action.toggleTo);
if (requiredAction === 'open') {
openedPanels.push(action.id);
} else if (requiredAction === 'close') {
remove(openedPanels, (item) => item === action.id);
}
return {