Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Do not resubscribe subscribers unnecessarily

Browse Source 
[MAILPOET-5555]
This commit is contained in:
David Remer
2023-08-31 10:02:00 +03:00
committed by Aschepikov
parent d7885621b3
commit ce4f19bd77
1 changed files with 28 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
mailpoet/lib/Subscribers/SubscriberSegmentRepository.php
View File

@@ -81,8 +81,34 @@ class SubscriberSegmentRepository extends Repository {
}
public function resetSubscriptions(SubscriberEntity $subscriber, array $segments): void {
$this->unsubscribeFromSegments($subscriber);
$this->subscribeToSegments($subscriber, $segments);
$existingSegments = array_values(array_filter(array_map(
function(SubscriberSegmentEntity $subscriberSegmentEntity): ?SegmentEntity { return $subscriberSegmentEntity->getSegment();
},
$this->findBy(['subscriber' => $subscriber, 'status' => SubscriberEntity::STATUS_SUBSCRIBED])
)));
$existingSegmentIds = array_map(function(SegmentEntity $segment): int { return $segment->getId() ?? 0;
}, $existingSegments);
$segmentIds = array_map(function(SegmentEntity $segment): int { return $segment->getId() ?? 0;
}, $segments);
$unsubscribedSegments = array_diff($existingSegmentIds, $segmentIds);
$newlySubscribedSegments = array_diff($segmentIds, $existingSegmentIds);
if (!$newlySubscribedSegments && !$unsubscribedSegments) {
return;
}
$unsubscribe = array_filter($existingSegments, function(SegmentEntity $segment) use ($unsubscribedSegments): bool {
return in_array($segment->getId(), $unsubscribedSegments);
});
$subscribe = array_filter($segments, function(SegmentEntity $segment) use ($newlySubscribedSegments): bool {
return in_array($segment->getId(), $newlySubscribedSegments);
});
if ($unsubscribe) {
$this->unsubscribeFromSegments($subscriber, $unsubscribe);
}
if ($subscribe) {
$this->subscribeToSegments($subscriber, $subscribe);
}
}
/**