Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Use typescript enum instead of list of strings

Browse Source 
[MAILPOET-2809]
This commit is contained in:
Pavel Dohnal
2020-04-28 10:35:26 +02:00
committed by Veljko V
parent d8c461f7d5
commit ce6885d53c
3 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
assets/js/src/common/styles.ts Normal file
View File

@@ -0,0 +1,7 @@
enum HorizontalAlignment {
Left = 'left',
Center = 'center',
Right = 'right',
}
export default HorizontalAlignment;

7
assets/js/src/form_editor/blocks/convert_alignment_to_margin.ts
View File

@@ -1,9 +1,10 @@
import HorizontalAlignment from 'common/styles';
function convert(alignment: 'left' | 'center' | 'right'): string { function convert(alignment: HorizontalAlignment): string {
if (alignment === 'right') { if (alignment === HorizontalAlignment.Right) {
return '0 0 0 auto'; return '0 0 0 auto';
} }
if (alignment === 'center') { if (alignment === HorizontalAlignment.Center) {
return '0 auto'; return '0 auto';
} }
return 'auto 0'; return 'auto 0';

7
assets/js/src/form_editor/components/form_settings/styles_settings_panel.jsx
View File

@@ -9,6 +9,7 @@ import MailPoet from 'mailpoet';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import { useSelect, useDispatch } from '@wordpress/data'; import { useSelect, useDispatch } from '@wordpress/data';
import { partial } from 'lodash'; import { partial } from 'lodash';
import HorizontalAlignment from 'common/styles';
import ColorSettings from 'form_editor/components/color_settings'; import ColorSettings from 'form_editor/components/color_settings';
import FontSizeSettings from 'form_editor/components/font_size_settings'; import FontSizeSettings from 'form_editor/components/font_size_settings';
@@ -84,9 +85,9 @@ const BasicSettingsPanel = ({ onToggle, isOpened }) => {
label={MailPoet.I18n.t('formSettingsAlignment')} label={MailPoet.I18n.t('formSettingsAlignment')}
onChange={partial(updateStyles, 'alignment')} onChange={partial(updateStyles, 'alignment')}
options={[ options={[
{ value: 'left', label: MailPoet.I18n.t('formSettingsAlignmentLeft') }, { value: HorizontalAlignment.Left, label: MailPoet.I18n.t('formSettingsAlignmentLeft') },
{ value: 'center', label: MailPoet.I18n.t('formSettingsAlignmentCenter') }, { value: HorizontalAlignment.Center, label: MailPoet.I18n.t('formSettingsAlignmentCenter') },
{ value: 'right', label: MailPoet.I18n.t('formSettingsAlignmentRight') }, { value: HorizontalAlignment.Right, label: MailPoet.I18n.t('formSettingsAlignmentRight') },
]} ]}
value={settings.alignment !== undefined ? settings.alignment : 'left'} value={settings.alignment !== undefined ? settings.alignment : 'left'}
/> />