Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add small code improvements

Browse Source 
I added small code style fixes based on the code review.
[MAILPOET-4686]
This commit is contained in:
Jan Lysý
2023-01-11 19:23:47 +01:00
committed by Aschepikov
parent 9f81b2c787
commit cef5959fff
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
mailpoet/views/deactivationPoll/index.html
View File

@ -1,14 +1,18 @@
<div class="mailpoet-deactivate-survey-modal" id="mailpoet-deactivate-survey"> <div class="mailpoet-deactivate-survey-modal" id="mailpoet-deactivate-survey-modal">
<div class="mailpoet-deactivate-survey-wrap"> <div class="mailpoet-deactivate-survey-wrap">
<div class="mailpoet-deactivate-survey"> <div class="mailpoet-deactivate-survey">
<script type="text/javascript"> <script type="text/javascript">
window.addEventListener('load', function(event) { window.addEventListener('load', function() {
var deactivateLink = document.querySelector('#the-list [data-slug="mailpoet"] span.deactivate a'); var deactivateLink = document.querySelector('#the-list [data-slug="mailpoet"] span.deactivate a');
var overlay = document.querySelector('#mailpoet-deactivate-survey'); var overlay = document.querySelector('#mailpoet-deactivate-survey-modal');
var closeButton = document.querySelector('#mailpoet-deactivate-survey-close'); var closeButton = document.querySelector('#mailpoet-deactivate-survey-close');
var formOpen = false; var formOpen = false;
if (!deactivateLink || !overlay || !closeButton) {
console.log('early return');
return;
}
deactivateLink.addEventListener('click', function (event) { deactivateLink.addEventListener('click', function (event) {
event.preventDefault(); event.preventDefault();
overlay.style.display = 'table'; overlay.style.display = 'table';
@ -33,8 +37,7 @@
var pd_callback = function(json) { var pd_callback = function(json) {
var obj = JSON.parse(json); var obj = JSON.parse(json);
var deactivateLink = document.querySelector('#the-list [data-slug="mailpoet"] span.deactivate a'); var deactivateLink = document.querySelector('#the-list [data-slug="mailpoet"] span.deactivate a');
var overlay = document.querySelector('#mailpoet-deactivate-survey'); var overlay = document.querySelector('#mailpoet-deactivate-survey-modal');
if (obj.result === 'already-registered' || obj.result === 'registered') { if (obj.result === 'already-registered' || obj.result === 'registered') {
overlay.style.display = 'none'; overlay.style.display = 'none';
location.href = deactivateLink.getAttribute('href'); location.href = deactivateLink.getAttribute('href');