Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove old outdated code

Browse Source 
[MAILPOET-3814]
This commit is contained in:
Pavel Dohnal
2021-10-13 11:24:43 +02:00
committed by Veljko V
parent cc76882164
commit cfa87a165d
2 changed files with 6 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Cron/Workers/WooCommercePastOrders.php
View File

@@ -60,8 +60,6 @@ class WooCommercePastOrders extends SimpleWorker {
}
foreach ($orderIds as $orderId) {
// clean all records for given order to fix wrong data inserted by a past buggy version
StatisticsWooCommercePurchases::where('order_id', $orderId)->deleteMany();
$this->woocommercePurchases->trackPurchase($orderId, false);
}

36
tests/integration/Cron/Workers/WooCommerceOrdersTest.php
View File

@@ -9,6 +9,7 @@ use MailPoet\Cron\Workers\WooCommercePastOrders;
use MailPoet\Models\ScheduledTask;
use MailPoet\Models\StatisticsClicks;
use MailPoet\Models\StatisticsWooCommercePurchases;
use MailPoet\Statistics\StatisticsClicksRepository;
use MailPoet\Statistics\Track\WooCommercePurchases;
use MailPoet\WooCommerce\Helper as WooCommerceHelper;
use MailPoetVendor\Idiorm\ORM;
@@ -32,7 +33,11 @@ class WooCommerceOrdersTest extends \MailPoetTest {
$this->woocommerceHelper = $this->createMock(WooCommerceHelper::class);
$this->woocommercePurchases = $this->createMock(WooCommercePurchases::class);
$this->worker = new WooCommercePastOrders($this->woocommerceHelper, $this->woocommercePurchases);
$this->worker = new WooCommercePastOrders(
$this->woocommerceHelper,
$this->diContainer->get(StatisticsClicksRepository::class),
$this->woocommercePurchases
);
$this->cronWorkerRunner = Stub::copy($this->diContainer->get(CronWorkerRunner::class), [
'timer' => microtime(true), // reset timer to avoid timeout during full test suite run
]);
@@ -136,35 +141,6 @@ class WooCommerceOrdersTest extends \MailPoetTest {
expect($tasks[0]->status)->equals(ScheduledTask::STATUS_COMPLETED);
}
public function testItResetsPreviouslyTrackedOrders() {
$this->woocommerceHelper->method('isWooCommerceActive')->willReturn(true);
$this->woocommerceHelper->method('wcGetOrders')->willReturnOnConsecutiveCalls([1, 2], [3], [4]);
$click = $this->createClick();
$this->woocommercePurchases->expects($this->exactly(4))->method('trackPurchase');
// wrong data inserted by a past buggy version should be removed for each order
// nothing new is inserted because we don't fully mock WC_Order (expect count 0)
$this->createOrder(1, $click);
$this->createOrder(2, $click);
$this->cronWorkerRunner->run($this->worker); // schedule
$this->cronWorkerRunner->run($this->worker); // prepare
$this->cronWorkerRunner->run($this->worker); // run for 1, 2
expect(StatisticsWooCommercePurchases::findMany())->count(0);
// don't remove data for unrelated orders (for order ID 4 row should not be removed)
$this->createOrder(3, $click);
$this->createOrder(4, $click);
$this->cronWorkerRunner->run($this->worker); // run for 3
$purchaseStats = StatisticsWooCommercePurchases::findMany();
expect($purchaseStats)->count(1);
expect($purchaseStats[0]->order_id)->equals(4);
// now row for order ID 4 should be removed as well
$this->cronWorkerRunner->run($this->worker); // run for 4
expect(StatisticsWooCommercePurchases::findMany())->count(0);
}
public function _after() {
$this->cleanup();
}