Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add test for orphan SubscriberSegments deletion

Browse Source 
[MAILPOET-3652]
This commit is contained in:
Brezo Cordero
2021-08-05 18:23:35 -05:00
committed by Veljko V
parent 67b88b862e
commit d2570001db
1 changed files with 43 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
tests/integration/Subscribers/SubscriberSaveControllerTest.php
View File

@@ -15,11 +15,15 @@ class SubscriberSaveControllerTest extends \MailPoetTest {
/** @var SegmentsRepository */ /** @var SegmentsRepository */
private $segmentsRepository; private $segmentsRepository;
/** @var SubscriberSegmentRepository */
private $subscriberSegmentRepository;
public function _before() { public function _before() {
parent::_before(); parent::_before();
$this->cleanup(); $this->cleanup();
$this->saveController = $this->diContainer->get(SubscriberSaveController::class); $this->saveController = $this->diContainer->get(SubscriberSaveController::class);
$this->segmentsRepository = $this->diContainer->get(SegmentsRepository::class); $this->segmentsRepository = $this->diContainer->get(SegmentsRepository::class);
$this->subscriberSegmentRepository = $this->diContainer->get(SubscriberSegmentRepository::class);
} }
public function testItCreatesNewSubscriber(): void { public function testItCreatesNewSubscriber(): void {
@@ -83,6 +87,38 @@ class SubscriberSaveControllerTest extends \MailPoetTest {
expect($subscriber->getSubscriberSegments())->count(1); expect($subscriber->getSubscriberSegments())->count(1);
} }
public function testItDeletesOrphanSubscriberSegmentsOnUpdate(): void {
$subscriber = $this->createSubscriber('second@test.com', SubscriberEntity::STATUS_UNCONFIRMED);
$segmentOne = $this->segmentsRepository->createOrUpdate('Segment One');
$segmentTwo = $this->segmentsRepository->createOrUpdate('Segment Two');
// Create orphan record on SubscriberSegments
$orphanSegment = $this->segmentsRepository->createOrUpdate('Orphan');
$this->createSubscriberSegment($subscriber, $orphanSegment);
$this->entityManager->remove($orphanSegment);
$this->entityManager->flush();
$subscriberSegments = $this->subscriberSegmentRepository->findBy(['subscriber' => $subscriber]);
expect($subscriberSegments)->count(1);
// Update subscriber with new segments
$data = [
'id' => $subscriber->getId(),
'first_name' => 'John',
'last_name' => 'Doe',
'status' => SubscriberEntity::STATUS_SUBSCRIBED,
'segments' => [
$segmentOne->getId(),
$segmentTwo->getId(),
],
];
$this->entityManager->clear();
$subscriber = $this->saveController->save($data);
// Check the $orphanSegment is gone
$subscriberSegments = $this->subscriberSegmentRepository->findBy(['subscriber' => $subscriber]);
expect($subscriberSegments)->count(2);
}
public function _after(): void { public function _after(): void {
$this->cleanup(); $this->cleanup();
} }
@@ -96,6 +132,13 @@ class SubscriberSaveControllerTest extends \MailPoetTest {
return $subscriber; return $subscriber;
} }
private function createSubscriberSegment(SubscriberEntity $subscriber, SegmentEntity $segment): SubscriberSegmentEntity {
$subscriberSegment = new SubscriberSegmentEntity($segment, $subscriber, SubscriberEntity::STATUS_SUBSCRIBED);
$this->entityManager->persist($subscriberSegment);
$this->entityManager->flush();
return $subscriberSegment;
}
private function cleanup(): void { private function cleanup(): void {
$this->truncateEntity(SegmentEntity::class); $this->truncateEntity(SegmentEntity::class);
$this->truncateEntity(SubscriberSegmentEntity::class); $this->truncateEntity(SubscriberSegmentEntity::class);