Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Replace instance_of asserts in integration tests

Browse Source 
[MAILPOET-4258]
This commit is contained in:
David Remer
2022-11-24 14:55:16 +02:00
committed by Jan Lysý
parent 2557171953
commit d2ec7bba42
69 changed files with 406 additions and 402 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mailpoet/tests/integration/API/JSON/ResponseBuilders/DynamicSegmentsResponseBuilderTest.php
View File

@ -83,7 +83,7 @@ class DynamicSegmentsResponseBuilderTest extends \MailPoetTest {
$wpUserSubscriber = $this->entityManager
->getRepository(SubscriberEntity::class)
->findOneBy(['email' => $wpUserEmail]);
assert($wpUserSubscriber instanceof SubscriberEntity);
$this->assertInstanceOf(SubscriberEntity::class, $wpUserSubscriber);
$wpUserSubscriber->setStatus(SubscriberEntity::STATUS_SUBSCRIBED);
$segment = $this->createDynamicSegmentEntity($name, $description);
$this->addDynamicFilter($segment, 'editor');

2
mailpoet/tests/integration/API/JSON/v1/AutomatedLatestContentTest.php
View File

@ -30,7 +30,7 @@ class AutomatedLatestContentTest extends \MailPoetTest {
// WP's default post type 'revision' is excluded from search
// https://codex.wordpress.org/Post_Types
$revisionPostType = get_post_type_object('revision');
assert($revisionPostType instanceof \WP_Post_Type);
$this->assertInstanceOf(\WP_Post_Type::class, $revisionPostType);
expect($revisionPostType->exclude_from_search)->true(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect(isset($response->data['revision']))->false();
}

4
mailpoet/tests/integration/API/JSON/v1/CustomFieldsTest.php
View File

@ -83,7 +83,7 @@ class CustomFieldsTest extends \MailPoetTest {
public function testItCanDeleteACustomField() {
$customField = $this->repository->findOneBy(['type' => 'date']);
assert($customField instanceof CustomFieldEntity);
$this->assertInstanceOf(CustomFieldEntity::class, $customField);
$customFieldId = $customField->getId();
$router = new CustomFields($this->repository, new CustomFieldsResponseBuilder());
@ -123,7 +123,7 @@ class CustomFieldsTest extends \MailPoetTest {
public function testItCanGetACustomField() {
$customField = $this->repository->findOneBy(['name' => 'CF: text']);
assert($customField instanceof CustomFieldEntity);
$this->assertInstanceOf(CustomFieldEntity::class, $customField);
$router = new CustomFields($this->repository, new CustomFieldsResponseBuilder());
$response = $router->get(['id' => $customField->getId()]);

6
mailpoet/tests/integration/API/JSON/v1/DynamicSegmentsTest.php
View File

@ -104,7 +104,7 @@ class DynamicSegmentsTest extends \MailPoetTest {
expect($response->meta['count'])->equals(1);
$this->entityManager->refresh($dynamicSegment);
assert($dynamicSegment instanceof SegmentEntity);
$this->assertInstanceOf(SegmentEntity::class, $dynamicSegment);
expect($dynamicSegment->getDeletedAt())->notNull();
}
@ -134,14 +134,14 @@ class DynamicSegmentsTest extends \MailPoetTest {
expect($response->meta['count'])->equals(1);
$this->entityManager->refresh($dynamicSegment);
assert($dynamicSegment instanceof SegmentEntity);
$this->assertInstanceOf(SegmentEntity::class, $dynamicSegment);
expect($dynamicSegment->getDeletedAt())->null();
}
public function testItCanDeleteASegment() {
$dynamicSegment = $this->createDynamicSegmentEntity('Delete test', 'description');
$dynamicSegmentFilter = $dynamicSegment->getDynamicFilters()->first();
assert($dynamicSegmentFilter instanceof DynamicSegmentFilterEntity);
$this->assertInstanceOf(DynamicSegmentFilterEntity::class, $dynamicSegmentFilter);
$response = $this->endpoint->delete(['id' => $dynamicSegment->getId()]);

4
mailpoet/tests/integration/API/JSON/v1/FormsTest.php
View File

@ -213,7 +213,7 @@ class FormsTest extends \MailPoetTest {
$this->formsRepository->flush();
$this->entityManager->refresh($this->form1);
assert($this->form1 instanceof FormEntity);
$this->assertInstanceOf(FormEntity::class, $this->form1);
expect($this->form1)->notNull();
$response = $this->endpoint->restore(['id' => $this->form1->getId()]);
@ -348,7 +348,7 @@ class FormsTest extends \MailPoetTest {
private function reloadForm(int $id): FormEntity {
$reloaded = $this->formsRepository->findOneById($id);
assert($reloaded instanceof FormEntity);
$this->assertInstanceOf(FormEntity::class, $reloaded);
return $reloaded;
}

6
mailpoet/tests/integration/API/JSON/v1/ImportExportTest.php
View File

@ -34,7 +34,7 @@ class ImportExportTest extends \MailPoetTest {
$response = $this->endpoint->setupWooCommerceInitialImport();
expect($response->status)->equals(200);
$task = $this->scheduledTasksRepository->findOneBy(['type' => WooCommerceSync::TASK_TYPE]);
assert($task instanceof ScheduledTaskEntity);
$this->assertInstanceOf(ScheduledTaskEntity::class, $task);
expect($task->getStatus())->equals(ScheduledTaskEntity::STATUS_SCHEDULED);
$now = time();
$scheduledAt = new Carbon($task->getScheduledAt());
@ -48,7 +48,7 @@ class ImportExportTest extends \MailPoetTest {
$this->entityManager->clear();
$this->endpoint->setupWooCommerceInitialImport();
$task = $this->scheduledTasksRepository->findOneBy(['type' => WooCommerceSync::TASK_TYPE]);
assert($task instanceof ScheduledTaskEntity);
$this->assertInstanceOf(ScheduledTaskEntity::class, $task);
expect($task->getStatus())->equals(ScheduledTaskEntity::STATUS_SCHEDULED);
$now = time();
$scheduledAt = new Carbon($task->getScheduledAt());
@ -62,7 +62,7 @@ class ImportExportTest extends \MailPoetTest {
$this->createTask(WooCommerceSync::TASK_TYPE, null);
$this->endpoint->setupWooCommerceInitialImport();
$task = $this->scheduledTasksRepository->findOneBy(['type' => WooCommerceSync::TASK_TYPE]);
assert($task instanceof ScheduledTaskEntity);
$this->assertInstanceOf(ScheduledTaskEntity::class, $task);
expect($task->getStatus())->equals(null);
$taskCount = $this->scheduledTasksRepository->countBy(['type' => WooCommerceSync::TASK_TYPE]);
expect($taskCount)->equals(1);

4
mailpoet/tests/integration/API/JSON/v1/NewsletterTemplatesTest.php
View File

@ -32,7 +32,7 @@ class NewsletterTemplatesTest extends \MailPoetTest {
public function testItCanGetANewsletterTemplate() {
$template = $this->newsletterTemplatesRepository->findOneBy(['name' => 'Template #1']);
assert($template instanceof NewsletterTemplateEntity);
$this->assertInstanceOf(NewsletterTemplateEntity::class, $template);
$endpoint = $this->diContainer->get(NewsletterTemplates::class);
$response = $endpoint->get(/* missing id */);
@ -126,7 +126,7 @@ class NewsletterTemplatesTest extends \MailPoetTest {
->equals('This template does not exist.');
$template = $this->newsletterTemplatesRepository->findOneBy(['name' => 'Template #1']);
assert($template instanceof NewsletterTemplateEntity);
$this->assertInstanceOf(NewsletterTemplateEntity::class, $template);
$templateId = $template->getId();
$response = $endpoint->delete(['id' => $template->getId()]);
expect($response->status)->equals(APIResponse::STATUS_OK);

18
mailpoet/tests/integration/API/JSON/v1/NewslettersTest.php
View File

@ -173,7 +173,7 @@ class NewslettersTest extends \MailPoetTest {
expect($response->status)->equals(APIResponse::STATUS_OK);
$newsletter = $this->newsletterRepository->findOneById($this->newsletter->getId());
assert($newsletter instanceof NewsletterEntity);
$this->assertInstanceOf(NewsletterEntity::class, $newsletter);
expect($response->data)->equals($this->newslettersResponseBuilder->build($newsletter, [
NewslettersResponseBuilder::RELATION_SEGMENTS,
NewslettersResponseBuilder::RELATION_OPTIONS,
@ -201,7 +201,7 @@ class NewslettersTest extends \MailPoetTest {
$response = $this->endpoint->save($newsletterData);
expect($response->status)->equals(APIResponse::STATUS_OK);
$updatedNewsletter = $this->newsletterRepository->findOneById($this->newsletter->getId());
assert($updatedNewsletter instanceof NewsletterEntity); // PHPStan
$this->assertInstanceOf(NewsletterEntity::class, $updatedNewsletter); // PHPStan
expect($response->data)->equals($this->newslettersResponseBuilder->build($updatedNewsletter, [NewslettersResponseBuilder::RELATION_SEGMENTS]));
expect($updatedNewsletter->getType())->equals('Updated type');
expect($updatedNewsletter->getSubject())->equals('Updated subject');
@ -326,13 +326,13 @@ class NewslettersTest extends \MailPoetTest {
$this->entityManager->clear();
$trashedNewsletter = $this->newsletterRepository->findOneById($this->newsletter->getId());
assert($trashedNewsletter instanceof NewsletterEntity);
$this->assertInstanceOf(NewsletterEntity::class, $trashedNewsletter);
expect($trashedNewsletter->getDeletedAt())->notNull();
$response = $this->endpoint->restore(['id' => $this->newsletter->getId()]);
expect($response->status)->equals(APIResponse::STATUS_OK);
$newsletter = $this->newsletterRepository->findOneById($this->newsletter->getId());
assert($newsletter instanceof NewsletterEntity);
$this->assertInstanceOf(NewsletterEntity::class, $newsletter);
expect($response->data)->equals($this->newslettersResponseBuilder->build($newsletter));
expect($response->data['deleted_at'])->null();
expect($response->meta['count'])->equals(1);
@ -342,7 +342,7 @@ class NewslettersTest extends \MailPoetTest {
$response = $this->endpoint->trash(['id' => $this->newsletter->getId()]);
expect($response->status)->equals(APIResponse::STATUS_OK);
$newsletter = $this->newsletterRepository->findOneById($this->newsletter->getId());
assert($newsletter instanceof NewsletterEntity);
$this->assertInstanceOf(NewsletterEntity::class, $newsletter);
expect($response->data)->equals($this->newslettersResponseBuilder->build($newsletter));
expect($response->data['deleted_at'])->notNull();
expect($response->meta['count'])->equals(1);
@ -367,7 +367,7 @@ class NewslettersTest extends \MailPoetTest {
$response = $this->endpoint->duplicate(['id' => $this->newsletter->getId()]);
expect($response->status)->equals(APIResponse::STATUS_OK);
$newsletterCopy = $this->newsletterRepository->findOneBy(['subject' => 'Copy of My Standard Newsletter']);
assert($newsletterCopy instanceof NewsletterEntity);
$this->assertInstanceOf(NewsletterEntity::class, $newsletterCopy);
expect($response->data)->equals($this->newslettersResponseBuilder->build($newsletterCopy));
expect($response->meta['count'])->equals(1);
@ -378,7 +378,7 @@ class NewslettersTest extends \MailPoetTest {
$response = $this->endpoint->duplicate(['id' => $this->postNotification->getId()]);
expect($response->status)->equals(APIResponse::STATUS_OK);
$newsletterCopy = $this->newsletterRepository->findOneBy(['subject' => 'Copy of My Post Notification']);
assert($newsletterCopy instanceof NewsletterEntity);
$this->assertInstanceOf(NewsletterEntity::class, $newsletterCopy);
expect($response->data)->equals($this->newslettersResponseBuilder->build($newsletterCopy));
expect($response->meta['count'])->equals(1);
}
@ -391,7 +391,7 @@ class NewslettersTest extends \MailPoetTest {
$response = $this->endpoint->create($data);
expect($response->status)->equals(APIResponse::STATUS_OK);
$newsletter = $this->newsletterRepository->findOneBy(['subject' => 'My New Newsletter']);
assert($newsletter instanceof NewsletterEntity);
$this->assertInstanceOf(NewsletterEntity::class, $newsletter);
expect($response->data)->equals($this->newslettersResponseBuilder->build($newsletter));
$response = $this->endpoint->create();
@ -407,7 +407,7 @@ class NewslettersTest extends \MailPoetTest {
$response = $this->endpoint->create($data);
expect($response->status)->equals(APIResponse::STATUS_OK);
$newsletter = $this->newsletterRepository->findOneBy(['subject' => 'My Automation newsletter']);
assert($newsletter instanceof NewsletterEntity);
$this->assertInstanceOf(NewsletterEntity::class, $newsletter);
expect($response->data)->equals($this->newslettersResponseBuilder->build($newsletter));
}

12
mailpoet/tests/integration/API/JSON/v1/SegmentsTest.php
View File

@ -98,7 +98,7 @@ class SegmentsTest extends \MailPoetTest {
$response = $this->endpoint->save($segmentData);
expect($response->status)->equals(APIResponse::STATUS_OK);
$segment = $this->segmentRepository->findOneBy(['name' => $name]);
assert($segment instanceof SegmentEntity);
$this->assertInstanceOf(SegmentEntity::class, $segment);
expect($response->data)->equals(
$this->responseBuilder->build($segment)
);
@ -119,14 +119,14 @@ class SegmentsTest extends \MailPoetTest {
$this->segmentRepository->flush();
$trashedSegment = $this->segmentRepository->findOneById($this->segment1->getId());
assert($trashedSegment instanceof SegmentEntity);
$this->assertInstanceOf(SegmentEntity::class, $trashedSegment);
expect($trashedSegment->getDeletedAt())->notNull();
$this->entityManager->clear();
$response = $this->endpoint->restore(['id' => $this->segment1->getId()]);
expect($response->status)->equals(APIResponse::STATUS_OK);
$segment = $this->segmentRepository->findOneById($trashedSegment->getId());
assert($segment instanceof SegmentEntity);
$this->assertInstanceOf(SegmentEntity::class, $segment);
expect($response->data)->equals(
$this->responseBuilder->build($segment)
);
@ -138,7 +138,7 @@ class SegmentsTest extends \MailPoetTest {
$response = $this->endpoint->trash(['id' => $this->segment2->getId()]);
$this->entityManager->clear();
$segment = $this->segmentRepository->findOneById($this->segment2->getId());
assert($segment instanceof SegmentEntity);
$this->assertInstanceOf(SegmentEntity::class, $segment);
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data)->equals(
@ -191,7 +191,7 @@ class SegmentsTest extends \MailPoetTest {
$response = $this->endpoint->trash(['id' => $this->segment2->getId()]);
$this->entityManager->refresh($this->segment2);
$segment = $this->segmentRepository->findOneById($this->segment2->getId());
assert($segment instanceof SegmentEntity);
$this->assertInstanceOf(SegmentEntity::class, $segment);
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data)->equals(
@ -211,7 +211,7 @@ class SegmentsTest extends \MailPoetTest {
public function testItCanDuplicateASegment() {
$response = $this->endpoint->duplicate(['id' => $this->segment1->getId()]);
$segment = $this->segmentRepository->findOneBy(['name' => 'Copy of Segment 1']);
assert($segment instanceof SegmentEntity);
$this->assertInstanceOf(SegmentEntity::class, $segment);
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data)->equals(

2
mailpoet/tests/integration/API/JSON/v1/SettingsTest.php
View File

@ -244,7 +244,7 @@ class SettingsTest extends \MailPoetTest {
'status' => ScheduledTaskEntity::STATUS_SCHEDULED
]
);
assert($task instanceof ScheduledTaskEntity);
$this->assertInstanceOf(ScheduledTaskEntity::class, $task);
expect($task->getScheduledAt())->lessThan(Carbon::now());
}