Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Replace instance_of asserts in integration tests

Browse Source 
[MAILPOET-4258]
This commit is contained in:
David Remer
2022-11-24 14:55:16 +02:00
committed by Jan Lysý
parent 2557171953
commit d2ec7bba42
69 changed files with 406 additions and 402 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mailpoet/tests/integration/Newsletter/Scheduler/PostNotificationTest.php
View File

@@ -87,7 +87,7 @@ class PostNotificationTest extends \MailPoetTest {
$newsletterId = $newsletter->getId();
$this->entityManager->clear();
$newsletter = $this->newslettersRepository->findOneById($newsletterId);
assert($newsletter instanceof NewsletterEntity);
$this->assertInstanceOf(NewsletterEntity::class, $newsletter);
$this->postNotificationScheduler->createPostNotificationSendingTask($newsletter);
expect($this->sendingQueuesRepository->findBy(['newsletter' => $newsletter]))->count(1);
}
@@ -106,7 +106,7 @@ class PostNotificationTest extends \MailPoetTest {
// another queue record should be created because the first one was paused
$scheduleOption = $newsletter->getOption(NewsletterOptionFieldEntity::NAME_SCHEDULE);
assert($scheduleOption instanceof NewsletterOptionEntity);
$this->assertInstanceOf(NewsletterOptionEntity::class, $scheduleOption);
$scheduleOption->setValue('* 10 * * *'); // different time to not clash with the first queue
$this->newsletterOptionsRepository->flush();
$sendingTask = $this->postNotificationScheduler->createPostNotificationSendingTask($newsletter);
@@ -124,7 +124,7 @@ class PostNotificationTest extends \MailPoetTest {
$newsletterId = $newsletter->getId();
$this->entityManager->clear();
$newsletter = $this->newslettersRepository->findOneById($newsletterId);
assert($newsletter instanceof NewsletterEntity);
$this->assertInstanceOf(NewsletterEntity::class, $newsletter);
$this->postNotificationScheduler->createPostNotificationSendingTask($newsletter);
expect($this->sendingQueuesRepository->findBy(['newsletter' => $newsletter]))->count(2);
}