Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Replace instance_of asserts in integration tests

Browse Source 
[MAILPOET-4258]
This commit is contained in:
David Remer
2022-11-24 14:55:16 +02:00
committed by Jan Lysý
parent 2557171953
commit d2ec7bba42
69 changed files with 406 additions and 402 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
mailpoet/tests/integration/Subscribers/SubscriberSubscribeControllerTest.php
View File

@ -68,7 +68,7 @@ class SubscriberSubscribeControllerTest extends \MailPoetTest {
$this->subscribeController->subscribe($data);
$subscriber = $this->subscribersRepository->findOneBy(['email' => $data[$this->obfuscatedEmail]]);
assert($subscriber instanceof SubscriberEntity);
$this->assertInstanceOf(SubscriberEntity::class, $subscriber);
expect($subscriber)->isInstanceOf(SubscriberEntity::class);
expect($subscriber->getStatus())->equals(SubscriberEntity::STATUS_SUBSCRIBED);
}
@ -86,7 +86,7 @@ class SubscriberSubscribeControllerTest extends \MailPoetTest {
$this->subscribeController->subscribe($data);
$subscriber = $this->subscribersRepository->findOneBy(['email' => $data[$this->obfuscatedEmail]]);
assert($subscriber instanceof SubscriberEntity);
$this->assertInstanceOf(SubscriberEntity::class, $subscriber);
expect($subscriber)->isInstanceOf(SubscriberEntity::class);
expect($subscriber->getStatus())->equals(SubscriberEntity::STATUS_UNCONFIRMED);
}
@ -106,13 +106,13 @@ class SubscriberSubscribeControllerTest extends \MailPoetTest {
$this->subscribeController->subscribe($data);
$subscriber = $this->subscribersRepository->findOneBy(['email' => $data[$this->obfuscatedEmail]]);
assert($subscriber instanceof SubscriberEntity);
$this->assertInstanceOf(SubscriberEntity::class, $subscriber);
expect($subscriber)->isInstanceOf(SubscriberEntity::class);
expect($subscriber->getStatus())->equals(SubscriberEntity::STATUS_SUBSCRIBED);
$subscriberCustomFields = $this->subscriberCustomFieldRepository->findBy(['subscriber' => $subscriber]);
expect($subscriberCustomFields)->count(1);
$subscriberCustomField = reset($subscriberCustomFields);
assert($subscriberCustomField instanceof SubscriberCustomFieldEntity);
$this->assertInstanceOf(SubscriberCustomFieldEntity::class, $subscriberCustomField);
expect($subscriberCustomField)->isInstanceOf(SubscriberCustomFieldEntity::class);
expect($subscriberCustomField->getSubscriber())->equals($subscriber);
expect($subscriberCustomField->getCustomField())->equals($customField);