Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix a bug in clickedStatsColor()

Browse Source 
The method clickedStatsColor() should return different color codes
depending on the percentage of clicks (> 30%, < 30% and > 10%, < 10%).
It receives the percentage value as an absolute number. There was a bug
in this method where it was checking for values greater than 3, between
3 and 1, and smaller than 1 instead of greater than 30, between 30 and
  10, and smaller than 10.

[MAILPOET-3324]
This commit is contained in:
Rodrigo Primo
2022-01-27 16:39:52 -03:00
committed by Veljko V
parent 509d97c2c0
commit d359c048e3
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mailpoet/lib/Twig/Functions.php
View File

@ -271,9 +271,9 @@ class Functions extends AbstractExtension {
} }
public function clickedStatsColor($clicked) { public function clickedStatsColor($clicked) {
if ($clicked > 3) { if ($clicked > 30) {
return '#7ed321'; return '#7ed321';
} elseif ($clicked > 1) { } elseif ($clicked > 10) {
return '#ff9f00'; return '#ff9f00';
} else { } else {
return '#f559c3'; return '#f559c3';