Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Rename sidebar form type to others

Browse Source 
[MAILPOET-2743]
This commit is contained in:
Rostislav Wolny
2020-04-23 11:24:50 +02:00
committed by Veljko V
parent cd0b9d49c5
commit d81c0d490b
5 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
assets/js/src/form_editor/components/preview.jsx
View File

@@ -79,7 +79,7 @@ const FormPreview = () => {
value={previewSettings.formType}
data-automation-id="form_type_selection"
>
<option value="sidebar">{MailPoet.I18n.t('placeFormSidebar')}</option>
<option value="others">{MailPoet.I18n.t('placeFormOthers')}</option>
<option value="below_post">{MailPoet.I18n.t('placeFormBellowPages')}</option>
<option value="fixed_bar">{MailPoet.I18n.t('placeFixedBarFormOnPages')}</option>
<option value="popup">{MailPoet.I18n.t('placePopupFormOnPages')}</option>
@@ -102,11 +102,11 @@ const FormPreview = () => {
title={MailPoet.I18n.t('formPreview')}
onLoad={() => setIframeLoaded(true)}
data-automation-id="form_preview_iframe"
scrolling={previewSettings.formType === 'sidebar' ? 'no' : 'yes'}
scrolling={previewSettings.formType === 'others' ? 'no' : 'yes'}
/>
{previewSettings.formType === 'sidebar' && previewSettings.displayType === 'desktop' && (
{previewSettings.formType === 'others' && previewSettings.displayType === 'desktop' && (
<div className="mailpoet_form_preview_disclaimer">
{MailPoet.I18n.t('formPreviewSidebarDisclaimer')}
{MailPoet.I18n.t('formPreviewOthersDisclaimer')}
</div>
)}
</Preview>

2
assets/js/src/form_editor/store/selectors.jsx
View File

@@ -60,7 +60,7 @@ export default {
// Otherwise create one based on settings
const previewSettings = {
displayType: 'desktop',
formType: 'sidebar',
formType: 'others',
};
const settings = state.formData.settings;
if (settings.placeFormBellowAllPages || settings.placeFormBellowAllPosts) {