Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove MP2 migration main class and its test class

Browse Source 
This commit removes the main MP2 migration class and its test class. It
also removes two SQL files that were used in the test class. One of
those files executed the following query:

`SET SQL_MODE = "NO_AUTO_VALUE_ON_ZERO"`

Removing this query made the tests inside SubscriberSegmentTest fail
when running the whole integration test suite. To work around this, I
added the above mentioned query to SubscriberSegmentTest. I'm not sure
why this test class fails without this query when running all the tests
but it doesn't when it is executed alone. Probably there is another test
class changing the SQL_MODE. Since SubscriberSegmentTest is a test class
for a Paris model that we will eventually remove, I decided it was not
necessary to investigate this further.

[MAILPOET-4376]
This commit is contained in:
Rodrigo Primo
2022-07-06 19:41:14 -03:00
committed by Veljko V
parent efab3be9ae
commit d874375c25
9 changed files with 2 additions and 3426 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mailpoet/tests/integration/Models/SubscriberSegmentTest.php
View File

@ -5,6 +5,7 @@ namespace MailPoet\Test\Models;
use MailPoet\Models\Segment;
use MailPoet\Models\Subscriber;
use MailPoet\Models\SubscriberSegment;
use MailPoetVendor\Idiorm\ORM;
class SubscriberSegmentTest extends \MailPoetTest {
public $wcSegment;
@ -15,6 +16,7 @@ class SubscriberSegmentTest extends \MailPoetTest {
public function _before() {
parent::_before();
ORM::raw_execute('SET SQL_MODE = "NO_AUTO_VALUE_ON_ZERO"');
$this->subscriber = Subscriber::createOrUpdate([
'email' => 'john.doe@mailpoet.com',
'first_name' => 'John',