Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Prevent deleting a list if attached to a form

Browse Source 
[MAILPOET-3661]
This commit is contained in:
Brezo Cordero
2021-07-28 23:45:54 -05:00
committed by Veljko V
parent 6dc0c62640
commit d9186e4230
4 changed files with 107 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
lib/API/JSON/v1/Segments.php
View File

@ -12,6 +12,7 @@ use MailPoet\Config\AccessControl;
use MailPoet\Doctrine\Validator\ValidationException;
use MailPoet\Entities\SegmentEntity;
use MailPoet\Entities\SubscriberEntity;
use MailPoet\Form\FormsRepository;
use MailPoet\Listing;
use MailPoet\Newsletter\Segment\NewsletterSegmentRepository;
use MailPoet\Segments\SegmentListingRepository;
@ -55,6 +56,9 @@ class Segments extends APIEndpoint {
/** @var NewsletterSegmentRepository */
private $newsletterSegmentRepository;
/** @var FormsRepository */
private $formsRepository;
public function __construct(
Listing\Handler $listingHandler,
SegmentsRepository $segmentsRepository,
@ -64,7 +68,8 @@ class Segments extends APIEndpoint {
SubscribersRepository $subscribersRepository,
WooCommerce $wooCommerce,
WP $wpSegment,
NewsletterSegmentRepository $newsletterSegmentRepository
NewsletterSegmentRepository $newsletterSegmentRepository,
FormsRepository $formsRepository
) {
$this->listingHandler = $listingHandler;
$this->wooCommerceSync = $wooCommerce;
@ -75,6 +80,7 @@ class Segments extends APIEndpoint {
$this->wpSegment = $wpSegment;
$this->segmentListingRepository = $segmentListingRepository;
$this->newsletterSegmentRepository = $newsletterSegmentRepository;
$this->formsRepository = $formsRepository;
}
public function get($data = []) {
@ -177,6 +183,23 @@ class Segments extends APIEndpoint {
]);
}
$activelyUsedFormNames = $this->formsRepository->getNamesOfFormsForSegments();
if (isset($activelyUsedFormNames[$segment->getId()])) {
return $this->badRequest([
APIError::BAD_REQUEST => str_replace(
'%$1s',
"'" . join("', '", $activelyUsedFormNames[$segment->getId()] ) . "'",
_nx(
'List cannot be deleted because it’s used for %$1s form',
'List cannot be deleted because it’s used for %$1s forms',
count($activelyUsedFormNames[$segment->getId()]),
'Alert shown when trying to delete segment, when it is assigned to a form.',
'mailpoet'
)
),
]);
}
// When the segment is of type WP_USERS we want to trash all subscribers who aren't subscribed in another list
if ($segment->getType() === SegmentEntity::TYPE_WP_USERS) {
$subscribers = $this->subscribersRepository->findExclusiveSubscribersBySegment((int)$segment->getId());