Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Refactor form api test to doctrine

Browse Source 
[MAILPOET-3037]
This commit is contained in:
Pavel Dohnal
2021-05-18 09:21:13 +02:00
committed by Veljko V
parent ad40585da4
commit d9ec70dfe6
1 changed files with 12 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
tests/integration/API/JSON/v1/FormsTest.php
View File

@ -9,7 +9,6 @@ use MailPoet\Entities\FormEntity;
use MailPoet\Entities\SegmentEntity; use MailPoet\Entities\SegmentEntity;
use MailPoet\Form\FormsRepository; use MailPoet\Form\FormsRepository;
use MailPoet\Form\PreviewPage; use MailPoet\Form\PreviewPage;
use MailPoet\Models\Form;
use MailPoet\Segments\SegmentsRepository; use MailPoet\Segments\SegmentsRepository;
use MailPoet\WP\Functions as WPFunctions; use MailPoet\WP\Functions as WPFunctions;
@ -51,7 +50,7 @@ class FormsTest extends \MailPoetTest {
$response = $this->endpoint->get(['id' => $this->form1->getId()]); $response = $this->endpoint->get(['id' => $this->form1->getId()]);
expect($response->status)->equals(APIResponse::STATUS_OK); expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data)->equals( expect($response->data)->equals(
$this->reloadForm((int)$this->form1->getId())->asArray() $this->reloadForm((int)$this->form1->getId())->toArray()
); );
} }
@ -74,7 +73,7 @@ class FormsTest extends \MailPoetTest {
$response = $this->endpoint->create(); $response = $this->endpoint->create();
expect($response->status)->equals(APIResponse::STATUS_OK); expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data)->equals( expect($response->data)->equals(
$this->reloadForm((int)$response->data['id'])->asArray() $this->reloadForm((int)$response->data['id'])->toArray()
); );
expect($response->data['name'])->equals(''); expect($response->data['name'])->equals('');
} }
@ -84,7 +83,7 @@ class FormsTest extends \MailPoetTest {
$formId = $response->data['id']; $formId = $response->data['id'];
expect($response->status)->equals(APIResponse::STATUS_OK); expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data)->equals( expect($response->data)->equals(
$this->reloadForm((int)$formId)->asArray() $this->reloadForm((int)$formId)->toArray()
); );
$response->data['styles'] = '/* Custom Styles */'; $response->data['styles'] = '/* Custom Styles */';
@ -100,7 +99,7 @@ class FormsTest extends \MailPoetTest {
$response = $this->endpoint->create(); $response = $this->endpoint->create();
expect($response->status)->equals(APIResponse::STATUS_OK); expect($response->status)->equals(APIResponse::STATUS_OK);
$form = $this->reloadForm((int)$response->data['id'])->asArray(); $form = $this->reloadForm((int)$response->data['id'])->toArray();
$form['name'] = 'Updated form'; $form['name'] = 'Updated form';
$response = $this->endpoint->saveEditor($form); $response = $this->endpoint->saveEditor($form);
@ -116,7 +115,7 @@ class FormsTest extends \MailPoetTest {
$response = $this->endpoint->create(); $response = $this->endpoint->create();
expect($response->status)->equals(APIResponse::STATUS_OK); expect($response->status)->equals(APIResponse::STATUS_OK);
$form = $this->reloadForm((int)$response->data['id'])->asArray(); $form = $this->reloadForm((int)$response->data['id'])->toArray();
$form['body'][] = [ $form['body'][] = [
'type' => FormEntity::HTML_BLOCK_TYPE, 'type' => FormEntity::HTML_BLOCK_TYPE,
'params' => [ 'params' => [
@ -136,7 +135,7 @@ class FormsTest extends \MailPoetTest {
$response = $this->endpoint->create(); $response = $this->endpoint->create();
expect($response->status)->equals(APIResponse::STATUS_OK); expect($response->status)->equals(APIResponse::STATUS_OK);
$form = $this->reloadForm((int)$response->data['id'])->asArray(); $form = $this->reloadForm((int)$response->data['id'])->toArray();
$form['body'][] = [ $form['body'][] = [
'type' => 'segment', 'type' => 'segment',
'params' => [ 'params' => [
@ -154,7 +153,7 @@ class FormsTest extends \MailPoetTest {
$response = $this->endpoint->create(); $response = $this->endpoint->create();
expect($response->status)->equals(APIResponse::STATUS_OK); expect($response->status)->equals(APIResponse::STATUS_OK);
$form = $this->reloadForm((int)$response->data['id'])->asArray(); $form = $this->reloadForm((int)$response->data['id'])->toArray();
$form['body'][] = [ $form['body'][] = [
'type' => 'segment', 'type' => 'segment',
'params' => [ 'params' => [
@ -276,7 +275,7 @@ class FormsTest extends \MailPoetTest {
]); ]);
expect($response->status)->equals(APIResponse::STATUS_OK); expect($response->status)->equals(APIResponse::STATUS_OK);
$form = $this->reloadForm((int)$this->form1->getId()); $form = $this->reloadForm((int)$this->form1->getId());
expect($form->status)->equals(FormEntity::STATUS_ENABLED); expect($form->getStatus())->equals(FormEntity::STATUS_ENABLED);
$response = $this->endpoint->setStatus([ $response = $this->endpoint->setStatus([
'status' => FormEntity::STATUS_DISABLED, 'status' => FormEntity::STATUS_DISABLED,
@ -284,7 +283,7 @@ class FormsTest extends \MailPoetTest {
]); ]);
expect($response->status)->equals(APIResponse::STATUS_OK); expect($response->status)->equals(APIResponse::STATUS_OK);
$form = $this->reloadForm((int)$this->form1->getId()); $form = $this->reloadForm((int)$this->form1->getId());
expect($form->status)->equals(FormEntity::STATUS_DISABLED); expect($form->getStatus())->equals(FormEntity::STATUS_DISABLED);
$response = $this->endpoint->setStatus([ $response = $this->endpoint->setStatus([
'status' => FormEntity::STATUS_DISABLED, 'status' => FormEntity::STATUS_DISABLED,
@ -318,9 +317,9 @@ class FormsTest extends \MailPoetTest {
$segmentsRepository->flush(); $segmentsRepository->flush();
} }
private function reloadForm(int $id): Form { private function reloadForm(int $id): FormEntity {
$reloaded = Form::findOne($id); $reloaded = $this->formsRepository->findOneById($id);
assert($reloaded instanceof Form); assert($reloaded instanceof FormEntity);
return $reloaded; return $reloaded;
} }