Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Deny deleting WooCommerce subscribers

Browse Source 
[MAILPOET-3138]
This commit is contained in:
Jan Lysý
2020-10-15 15:31:40 +02:00
committed by Veljko V
parent b8d66c8cd8
commit da15182979
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/Subscribers/SubscribersRepository.php
View File

@ -116,6 +116,7 @@ class SubscribersRepository extends Repository {
$count = $queryBuilder->delete(SubscriberEntity::class, 's')
->where('s.id IN (:ids)')
->andWhere('s.wpUserId IS NULL')
->andWhere('s.isWoocommerceUser = false')
->setParameter('ids', $ids)
->getQuery()->execute();
});

8
tests/integration/Segments/WooCommerceTest.php
View File

@ -269,7 +269,7 @@ class WooCommerceTest extends \MailPoetTest {
expect($subscribers->count())->equals(4);
}
public function testItRemovesRegisteredCustomersFromTrash() {
public function testItDoesntRemoveRegisteredCustomersFromTrash() {
$user = $this->insertRegisteredCustomer();
$this->woocommerceSegment->synchronizeCustomers();
$subscriber = Subscriber::where("email", $user->user_email) // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps
@ -281,10 +281,10 @@ class WooCommerceTest extends \MailPoetTest {
$subscriber = Subscriber::where("email", $user->user_email) // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps
->where('is_woocommerce_user', 1)
->findOne();
expect($subscriber->deletedAt)->null();
expect($subscriber->deletedAt)->notNull();
}
public function testItRemovesGuestCustomersFromTrash() {
public function testItDoesntRemoveGuestCustomersFromTrash() {
$guest = $this->insertGuestCustomer();
$this->woocommerceSegment->synchronizeCustomers();
$subscriber = Subscriber::where("email", $guest['email'])
@ -296,7 +296,7 @@ class WooCommerceTest extends \MailPoetTest {
$subscriber = Subscriber::where("email", $guest['email'])
->where('is_woocommerce_user', 1)
->findOne();
expect($subscriber->deletedAt)->null();
expect($subscriber->deletedAt)->notNull();
}
public function testItRemovesOrphanedSubscribers() {