Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add BC for importing older exported templates

Browse Source 
We allow exporting templates as JSON and templates exported from the older plugin versions use thumbnail key for storing the image data.
[MAILPOET-2686]
This commit is contained in:
Rostislav Wolny
2021-10-20 13:41:00 +02:00
committed by Veljko V
parent 5134713c2d
commit dd0a19a314
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/NewsletterTemplates/NewsletterTemplatesRepository.php
View File

@@ -49,8 +49,13 @@ class NewsletterTemplatesRepository extends Repository {
} }
if (isset($data['thumbnail'])) { if (isset($data['thumbnail'])) {
// Backward compatibility for importing templates exported from older versions
if (strpos($data['thumbnail'], 'data:image') === 0) {
$data['thumbnail_data'] = $data['thumbnail'];
} else {
$template->setThumbnail($data['thumbnail']); $template->setThumbnail($data['thumbnail']);
} }
}
if (isset($data['thumbnail_data'])) { if (isset($data['thumbnail_data'])) {
$template->setThumbnailData($data['thumbnail_data']); $template->setThumbnailData($data['thumbnail_data']);

11
tests/integration/NewsletterTemplates/NewsletterTemplatesRepositoryTest.php
View File

@@ -54,6 +54,17 @@ class NewsletterTemplatesRepositoryTest extends \MailPoetTest {
expect($templates[0]->getName())->equals('Testing template 5'); expect($templates[0]->getName())->equals('Testing template 5');
} }
public function testItCanCreateFromOldDataFormat() {
$createdTemplate = $this->newsletterTemplatesRepository->createOrUpdate([
'name' => 'Another template',
'body' => '{"content": {}, "globalStyles": {}}',
'thumbnail' => 'data:image/gif;base64,R0lGODlhAQABAAAAACw=',
]);
expect($createdTemplate->getName())->equals('Another template');
expect($createdTemplate->getBody())->equals(['content' => [], 'globalStyles' => []]);
expect($createdTemplate->getThumbnailData())->equals('data:image/gif;base64,R0lGODlhAQABAAAAACw=');
}
public function _after() { public function _after() {
$this->truncateEntity(NewsletterTemplateEntity::class); $this->truncateEntity(NewsletterTemplateEntity::class);
} }