From dd5a11a34febbb2fdeb3348a7c31051a6b5eb30a Mon Sep 17 00:00:00 2001 From: Jan Jakes Date: Fri, 27 Oct 2023 09:55:39 +0200 Subject: [PATCH] Fix and improve SchedulerTest::testItDeletesScheduledAutomaticEmailWhenUserDoesNotExist() Having no segment and no task subscriber caused the test pass even without removing the subscriber. [MAILPOET-4375] --- mailpoet/tests/integration/Cron/Workers/SchedulerTest.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/mailpoet/tests/integration/Cron/Workers/SchedulerTest.php b/mailpoet/tests/integration/Cron/Workers/SchedulerTest.php index 9eb3a78a2e..2240fafa19 100644 --- a/mailpoet/tests/integration/Cron/Workers/SchedulerTest.php +++ b/mailpoet/tests/integration/Cron/Workers/SchedulerTest.php @@ -800,7 +800,10 @@ class SchedulerTest extends \MailPoetTest { public function testItDeletesScheduledAutomaticEmailWhenUserDoesNotExist() { $newsletter = $this->_createNewsletter(NewsletterEntity::TYPE_AUTOMATIC, NewsletterEntity::STATUS_SCHEDULED); $subscriber = $this->_createSubscriber(); - $this->createTaskWithQueue($newsletter); + $task = $this->createTaskWithQueue($newsletter); + $this->createTaskSubscriber($task, $subscriber); + + verify($this->scheduledTasksRepository->findOneByNewsletter($newsletter))->notNull(); // remove subscriber, but not scheduled task subscriber $this->entityManager->getConnection()->delete( @@ -812,8 +815,7 @@ class SchedulerTest extends \MailPoetTest { // task should be deleted $scheduler = $this->getScheduler(); $scheduler->process(); - $task = $this->scheduledTasksRepository->findOneByNewsletter($newsletter); - verify($task)->null(); + verify($this->scheduledTasksRepository->findOneByNewsletter($newsletter))->null(); } public function testItProcessesScheduledAutomaticEmailWhenSendingToSegment() {