Refactor tests [MAILOET-1677]

This commit is contained in:
Amine Ben hammou
2019-03-18 23:23:59 +01:00
committed by M. Shull
parent 4fc53d2b36
commit de3d3331b0
3 changed files with 19 additions and 23 deletions

View File

@@ -4,8 +4,8 @@ namespace MailPoet\Test\Models;
use MailPoet\Models\UserFlag;
class UserFlagTest extends \MailPoetTest {
function testItCanCreateOrUpdate() {
function testCreateOrUpdateCreatesNewFlags() {
expect(UserFlag::count())->equals(0);
$created_flag = UserFlag::createOrUpdate([
@@ -13,10 +13,23 @@ class UserFlagTest extends \MailPoetTest {
'name' => 'first_flag',
'value' => 'foo'
]);
$other_flag = UserFlag::createOrUpdate([
'user_id' => 3,
'name' => 'second_flag',
'value' => 'bar'
]);
expect($created_flag->id > 0)->true();
expect($created_flag->getErrors())->false();
expect(UserFlag::count())->equals(1);
expect($other_flag->id != $created_flag->id)->true();
expect(UserFlag::count())->equals(2);
}
function testCreateOrUpdateUpdatesExistingFlags() {
$created_flag = UserFlag::createOrUpdate([
'user_id' => 3,
'name' => 'first_flag',
'value' => 'foo'
]);
$updated_flag = UserFlag::createOrUpdate([
'user_id' => 3,
'name' => 'first_flag',
@@ -25,14 +38,6 @@ class UserFlagTest extends \MailPoetTest {
expect($updated_flag->id)->equals($created_flag->id);
expect($updated_flag->value)->equals('bar');
expect(UserFlag::count())->equals(1);
$other_flag = UserFlag::createOrUpdate([
'user_id' => 3,
'name' => 'second_flag',
'value' => 'bar'
]);
expect($other_flag->id != $created_flag)->true();
expect(UserFlag::count())->equals(2);
}
function _after() {