Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

clearing the sending queue rendered body and subject

Browse Source 
The new body and subject would be automatically rendered when
resuming sending
This commit is contained in:
Amine Ben hammou
2017-07-21 13:17:41 +00:00
parent ca4f1c9387
commit df9ba7e6c8
2 changed files with 30 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/API/JSON/v1/Newsletters.php
View File

@ -110,6 +110,13 @@ class Newsletters extends APIEndpoint {
}
}
$queue = $newsletter->getQueue();
if ($queue) {
$queue->newsletter_rendered_body = null;
$queue->newsletter_rendered_subject = null;
$queue->save();
}
Hooks::doAction('mailpoet_api_newsletters_save_after', $newsletter);
return $this->successResponse($newsletter->asArray());
@ -455,4 +462,4 @@ class Newsletters extends APIEndpoint {
);
}
}
}
}

22
tests/unit/API/JSON/v1/NewslettersTest.php
View File

@ -163,6 +163,28 @@ class NewslettersTest extends \MailPoetTest {
expect($updated_newsletter->subject)->equals('My Updated Newsletter');
}
function testItCanClearRenderedQueueUponSave() {
$sending_queue = SendingQueue::create();
$sending_queue->newsletter_id = 1;
$sending_queue->status = SendingQueue::STATUS_SCHEDULED;
$sending_queue->newsletter_rendered_body = 'Rendered body ...';
$sending_queue->newsletter_rendered_subject = 'Rendered subject ...';
$sending_queue->save();
$router = new Newsletters();
$newsletter_data = array(
'id' => $this->newsletter->id,
'subject' => 'My Updated Newsletter'
);
$response = $router->save($newsletter_data);
$updated_newsletter = Newsletter::findOne($this->newsletter->id);
$updated_queue = $updated_newsletter->getQueue();
expect($response->status)->equals(APIResponse::STATUS_OK);
expect(unserialize($updated_queue->newsletter_rendered_body))->equals(null);
expect(unserialize($updated_queue->newsletter_rendered_subject))->equals(null);
}
function testItCanUpdatePostNotificationScheduleUponSave() {
$newsletter_options = array(
'intervalType',