Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Refactor import export test to doctrine

Browse Source 
[MAILPOET-3625]
This commit is contained in:
Pavel Dohnal
2021-08-18 15:28:07 +02:00
committed by Veljko V
parent 0daaac8abf
commit e31707903e
1 changed files with 38 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

65
tests/integration/API/JSON/v1/ImportExportTest.php
View File

@@ -5,7 +5,8 @@ namespace MailPoet\Test\API\JSON\v1;
use MailPoet\API\JSON\v1\ImportExport; use MailPoet\API\JSON\v1\ImportExport;
use MailPoet\Cron\Workers\WooCommerceSync; use MailPoet\Cron\Workers\WooCommerceSync;
use MailPoet\DI\ContainerWrapper; use MailPoet\DI\ContainerWrapper;
use MailPoet\Models\ScheduledTask; use MailPoet\Entities\ScheduledTaskEntity;
use MailPoet\Newsletter\Sending\ScheduledTasksRepository;
use MailPoet\WP\Functions as WPFunctions; use MailPoet\WP\Functions as WPFunctions;
use MailPoetVendor\Carbon\Carbon; use MailPoetVendor\Carbon\Carbon;
@@ -14,54 +15,64 @@ class ImportExportTest extends \MailPoetTest {
/** @var ImportExport */ /** @var ImportExport */
private $endpoint; private $endpoint;
/** @var ScheduledTasksRepository */
private $scheduledTasksRepository;
public function _before() { public function _before() {
parent::_before(); parent::_before();
$this->endpoint = ContainerWrapper::getInstance()->get(ImportExport::class); $this->endpoint = ContainerWrapper::getInstance()->get(ImportExport::class);
ScheduledTask::where('type', WooCommerceSync::TASK_TYPE)->deleteMany(); $this->scheduledTasksRepository = ContainerWrapper::getInstance()->get(ScheduledTasksRepository::class);
$this->entityManager->createQueryBuilder()
->delete(ScheduledTaskEntity::class, 's')
->where('s.type = :type')
->setParameter(':type',WooCommerceSync::TASK_TYPE )
->getQuery()
->execute();
} }
public function testItSchedulesTaskWhenNoneExistss() { public function testItSchedulesTaskWhenNoneExists() {
$response = $this->endpoint->setupWooCommerceInitialImport(); $response = $this->endpoint->setupWooCommerceInitialImport();
expect($response->status)->equals(200); expect($response->status)->equals(200);
$task = ScheduledTask::where('type', WooCommerceSync::TASK_TYPE)->findOne(); $task = $this->scheduledTasksRepository->findOneBy(['type' => WooCommerceSync::TASK_TYPE]);
assert($task instanceof ScheduledTask); assert($task instanceof ScheduledTaskEntity);
expect($task->status)->equals(ScheduledTask::STATUS_SCHEDULED); expect($task->getStatus())->equals(ScheduledTaskEntity::STATUS_SCHEDULED);
$now = time(); $now = time();
$scheduledAt = new Carbon($task->scheduledAt); $scheduledAt = new Carbon($task->getScheduledAt());
expect($scheduledAt->timestamp)->greaterOrEquals($now - 1); expect($scheduledAt->timestamp)->greaterOrEquals($now - 1);
expect($scheduledAt->timestamp)->lessOrEquals($now + 1); expect($scheduledAt->timestamp)->lessOrEquals($now + 1);
} }
public function testItReschedulesScheduledTaskToNow() { public function testItReschedulesScheduledTaskToNow() {
$originalSchedule = Carbon::createFromTimestamp(time() + 3000); $originalSchedule = Carbon::createFromTimestamp((int)current_time('timestamp') + 3000);
$this->createTask(WooCommerceSync::TASK_TYPE, ScheduledTask::STATUS_SCHEDULED, $originalSchedule); $this->createTask(WooCommerceSync::TASK_TYPE, ScheduledTaskEntity::STATUS_SCHEDULED, $originalSchedule);
$this->entityManager->clear();
$this->endpoint->setupWooCommerceInitialImport(); $this->endpoint->setupWooCommerceInitialImport();
$task = ScheduledTask::where('type', WooCommerceSync::TASK_TYPE)->findOne(); $task = $this->scheduledTasksRepository->findOneBy(['type' => WooCommerceSync::TASK_TYPE]);
assert($task instanceof ScheduledTask); assert($task instanceof ScheduledTaskEntity);
expect($task->status)->equals(ScheduledTask::STATUS_SCHEDULED); expect($task->getStatus())->equals(ScheduledTaskEntity::STATUS_SCHEDULED);
$now = time(); $now = time();
$scheduledAt = new Carbon($task->scheduledAt); $scheduledAt = new Carbon($task->getScheduledAt());
expect($scheduledAt->timestamp)->greaterOrEquals($now - 1); expect($scheduledAt->timestamp)->greaterOrEquals($now - 1);
expect($scheduledAt->timestamp)->lessOrEquals($now + 1); expect($scheduledAt->timestamp)->lessOrEquals($now + 1);
$taskCount = ScheduledTask::where('type', WooCommerceSync::TASK_TYPE)->count(); $taskCount = $this->scheduledTasksRepository->countBy(['type' => WooCommerceSync::TASK_TYPE]);
expect($taskCount)->equals(1); expect($taskCount)->equals(1);
} }
public function testItDoesNothingForRunningTask() { public function testItDoesNothingForRunningTask() {
$this->createTask(WooCommerceSync::TASK_TYPE, null); $this->createTask(WooCommerceSync::TASK_TYPE, null);
$this->endpoint->setupWooCommerceInitialImport(); $this->endpoint->setupWooCommerceInitialImport();
$task = ScheduledTask::where('type', WooCommerceSync::TASK_TYPE)->findOne(); $task = $this->scheduledTasksRepository->findOneBy(['type' => WooCommerceSync::TASK_TYPE]);
assert($task instanceof ScheduledTask); assert($task instanceof ScheduledTaskEntity);
expect($task->status)->equals(null); expect($task->getStatus())->equals(null);
$taskCount = ScheduledTask::where('type', WooCommerceSync::TASK_TYPE)->count(); $taskCount = $this->scheduledTasksRepository->countBy(['type' => WooCommerceSync::TASK_TYPE]);
expect($taskCount)->equals(1); expect($taskCount)->equals(1);
} }
public function testItIgnoresCompletedAndPausedTasks() { public function testItIgnoresCompletedAndPausedTasks() {
$this->createTask(WooCommerceSync::TASK_TYPE, ScheduledTask::STATUS_PAUSED); $this->createTask(WooCommerceSync::TASK_TYPE, ScheduledTaskEntity::STATUS_PAUSED);
$this->createTask(WooCommerceSync::TASK_TYPE, ScheduledTask::STATUS_COMPLETED); $this->createTask(WooCommerceSync::TASK_TYPE, ScheduledTaskEntity::STATUS_COMPLETED);
$this->endpoint->setupWooCommerceInitialImport(); $this->endpoint->setupWooCommerceInitialImport();
$taskCount = ScheduledTask::where('type', WooCommerceSync::TASK_TYPE)->count(); $taskCount = $this->scheduledTasksRepository->countBy(['type' => WooCommerceSync::TASK_TYPE]);
expect($taskCount)->equals(3); expect($taskCount)->equals(3);
} }
@@ -69,11 +80,11 @@ class ImportExportTest extends \MailPoetTest {
if (!$scheduledAt) { if (!$scheduledAt) {
Carbon::createFromTimestamp(WPFunctions::get()->currentTime('timestamp')); Carbon::createFromTimestamp(WPFunctions::get()->currentTime('timestamp'));
} }
$task = ScheduledTask::create(); $task = new ScheduledTaskEntity();
$task->type = $type; $task->setType($type);
$task->status = $status; $task->setStatus($status);
$task->scheduledAt = $scheduledAt; $task->setScheduledAt($scheduledAt);
$task->save(); $this->scheduledTasksRepository->persist($task);
return $task; $this->scheduledTasksRepository->flush();
} }
} }