Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Refactor filter factory into multiple functions

Browse Source 
[MAILPOET-3220]
This commit is contained in:
Pavel Dohnal
2021-05-12 11:10:24 +02:00
committed by Veljko V
parent 4fff3ff56c
commit e3bd23a2ee
1 changed files with 35 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
lib/Segments/DynamicSegments/FilterFactory.php
View File

@ -78,30 +78,46 @@ class FilterFactory {
$action = $filterData->getParam('action'); $action = $filterData->getParam('action');
switch ($filterType) { switch ($filterType) {
case DynamicSegmentFilterData::TYPE_USER_ROLE: case DynamicSegmentFilterData::TYPE_USER_ROLE:
if ($action === SubscriberSubscribedDate::TYPE) { return $this->userRole($action);
return $this->subscriberSubscribedDate;
}
return $this->userRole;
case DynamicSegmentFilterData::TYPE_EMAIL: case DynamicSegmentFilterData::TYPE_EMAIL:
if ($action === EmailOpensAbsoluteCountAction::TYPE) { return $this->email($action);
return $this->emailOpensAbsoluteCount;
}
return $this->emailAction;
case DynamicSegmentFilterData::TYPE_WOOCOMMERCE_SUBSCRIPTION: case DynamicSegmentFilterData::TYPE_WOOCOMMERCE_SUBSCRIPTION:
return $this->wooCommerceSubscription; return $this->wooCommerceSubscription();
case DynamicSegmentFilterData::TYPE_WOOCOMMERCE: case DynamicSegmentFilterData::TYPE_WOOCOMMERCE:
if ($action === WooCommerceProduct::ACTION_PRODUCT) { return $this->wooCommerce($action);
return $this->wooCommerceProduct;
} elseif ($action === WooCommerceNumberOfOrders::ACTION_NUMBER_OF_ORDERS) {
return $this->wooCommerceNumberOfOrders;
} elseif ($action === WooCommerceTotalSpent::ACTION_TOTAL_SPENT) {
return $this->wooCommerceTotalSpent;
} elseif ($action === WooCommerceCountry::ACTION_CUSTOMER_COUNTRY) {
return $this->wooCommerceCountry;
}
return $this->wooCommerceCategory;
default: default:
throw new InvalidFilterException('Invalid type', InvalidFilterException::INVALID_TYPE); throw new InvalidFilterException('Invalid type', InvalidFilterException::INVALID_TYPE);
} }
} }
private function userRole($action) {
if ($action === SubscriberSubscribedDate::TYPE) {
return $this->subscriberSubscribedDate;
}
return $this->userRole;
}
private function email($action) {
if ($action === EmailOpensAbsoluteCountAction::TYPE) {
return $this->emailOpensAbsoluteCount;
}
return $this->emailAction;
}
private function wooCommerceSubscription() {
return $this->wooCommerceSubscription;
}
private function wooCommerce($action) {
if ($action === WooCommerceProduct::ACTION_PRODUCT) {
return $this->wooCommerceProduct;
} elseif ($action === WooCommerceNumberOfOrders::ACTION_NUMBER_OF_ORDERS) {
return $this->wooCommerceNumberOfOrders;
} elseif ($action === WooCommerceTotalSpent::ACTION_TOTAL_SPENT) {
return $this->wooCommerceTotalSpent;
} elseif ($action === WooCommerceCountry::ACTION_CUSTOMER_COUNTRY) {
return $this->wooCommerceCountry;
}
return $this->wooCommerceCategory;
}
} }