Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix checkGenericClassInNonGenericObjectType PHPStan errors

Browse Source 
This commit removes the checkGenericClassInNonGenericObjectType flag
from PHPStan configuration files and fixes all associated errors in our
code base.

[MAILPOET-3236]
This commit is contained in:
Rodrigo Primo
2021-07-28 15:08:39 -03:00
committed by Veljko V
parent f0dc0b3556
commit e59992cc16
16 changed files with 51 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/integration/Newsletter/NewsletterSaveControllerTest.php
View File

@@ -112,6 +112,7 @@ class NewsletterSaveControllerTest extends \MailPoetTest {
return $optionField && $optionField->getName() === 'schedule';
})->first();
assert($scheduleOption instanceof NewsletterOptionEntity); // PHPStan
expect($scheduleOption->getValue())->equals('0 14 * * 1');
// schedule should be recalculated when options change
@@ -123,6 +124,7 @@ class NewsletterSaveControllerTest extends \MailPoetTest {
return $optionField && $optionField->getName() === 'schedule';
})->first();
assert($scheduleOption instanceof NewsletterOptionEntity); // PHPStan
expect($scheduleOption->getValue())->equals('* * * * *');
}
@@ -165,6 +167,7 @@ class NewsletterSaveControllerTest extends \MailPoetTest {
return $optionField && $optionField->getName() === 'schedule';
})->first();
expect($task1->getScheduledAt())->notEquals($currentTime);
assert($scheduleOption instanceof NewsletterOptionEntity); // PHPStan
expect($task1->getScheduledAt())->equals(Scheduler::getNextRunDate($scheduleOption->getValue()));
expect($task2->getScheduledAt())->null();
}
@@ -187,7 +190,11 @@ class NewsletterSaveControllerTest extends \MailPoetTest {
$newsletter = $this->saveController->save($newsletterData);
expect(count($newsletter->getNewsletterSegments()))->equals(1);
expect($newsletter->getNewsletterSegments()->first()->getSegment()->getName())->equals('Segment 1');
$newsletterSegment = $newsletter->getNewsletterSegments()->first();
assert($newsletterSegment instanceof NewsletterSegmentEntity); // PHPStan
$segment = $newsletterSegment->getSegment();
assert($segment instanceof SegmentEntity); // PHPStan
expect($segment->getName())->equals('Segment 1');
}
public function testItDeletesSendingQueueAndSetsNewsletterStatusToDraftWhenItIsUnscheduled() {