Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Refactor SubscriberFinder::addSubscribersToTaskFromSegments to return void

Browse Source 
We removed the return value to prevent us from using it to check if there were recipients.
It is not 100% reliable for that purpose because it returns 0 for a repeated call.
[MAILPOET-6346]
This commit is contained in:
Rostislav Wolny
2024-11-27 11:22:07 +01:00
committed by Aschepikov
parent 74de985620
commit e6abec74d4
3 changed files with 38 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
mailpoet/lib/API/JSON/v1/SendingQueue.php
View File

@@ -166,7 +166,8 @@ class SendingQueue extends APIEndpoint {
$segments = $newsletter->getSegmentIds();
$this->scheduledTasksRepository->refresh($scheduledTask);
$subscribersCount = $this->subscribersFinder->addSubscribersToTaskFromSegments($scheduledTask, $segments, $newsletter->getFilterSegmentId());
$this->subscribersFinder->addSubscribersToTaskFromSegments($scheduledTask, $segments, $newsletter->getFilterSegmentId());
$subscribersCount = $scheduledTask->getSubscribers()->count();
if (!$subscribersCount) {
return $this->errorResponse([