diff --git a/lib/Models/Model.php b/lib/Models/Model.php index 6eccc06c3e..6528d23f6b 100644 --- a/lib/Models/Model.php +++ b/lib/Models/Model.php @@ -16,15 +16,15 @@ class Model extends \Sudzy\ValidModel { parent::save(); return true; } catch (\Sudzy\ValidationException $e) { - return false; + return array_unique($e->getValidationErrors()); } catch (\PDOException $e) { - return false; + return $e->getMessage(); } } private function setTimestamp() { if ($this->created_at === null) { - $this->created_at = date("Y-m-d H:i:s"); + $this->created_at = date('Y-m-d H:i:s'); } } } diff --git a/lib/Models/Subscriber.php b/lib/Models/Subscriber.php index c2ca8d9876..6f9d3adcab 100644 --- a/lib/Models/Subscriber.php +++ b/lib/Models/Subscriber.php @@ -83,12 +83,7 @@ class Subscriber extends Model { } $subscriber->hydrate($data); - $saved = $subscriber->save(); + return $subscriber->save(); - if($saved === false) { - return $subscriber->getValidationErrors(); - } else { - return true; - } } } diff --git a/lib/Router/Newsletters.php b/lib/Router/Newsletters.php index f98c0f721a..826ca76ef0 100644 --- a/lib/Router/Newsletters.php +++ b/lib/Router/Newsletters.php @@ -27,13 +27,8 @@ class Newsletters { function save($args) { $model = Newsletter::create(); $model->hydrate($args); - $saved = $model->save(); - - if(!$saved) { - wp_send_json($model->getValidationErrors()); - } - - wp_send_json(true); + $result = $model->save(); + wp_send_json($result); } function update($args) { diff --git a/lib/Router/Segments.php b/lib/Router/Segments.php index ea42a18764..7fc0da1777 100644 --- a/lib/Router/Segments.php +++ b/lib/Router/Segments.php @@ -25,13 +25,8 @@ class Segments { function save($args) { $model = Segment::create(); $model->hydrate($args); - $saved = $model->save(); - - if(!$saved) { - wp_send_json($model->getValidationErrors()); - } - - wp_send_json(true); + $result = $model->save(); + wp_send_json($result); } function update($args) { diff --git a/lib/Router/Subscribers.php b/lib/Router/Subscribers.php index 2b635430c8..efd41d7c9c 100644 --- a/lib/Router/Subscribers.php +++ b/lib/Router/Subscribers.php @@ -1,7 +1,8 @@ see('No newsletters found'); + $I->waitForElement('.no-items', $this->waitTime); $I->click('New', '#newsletters'); $I->fillField('Subject', 'first newsletter'); $I->fillField('Body', 'some body'); diff --git a/tests/unit/Models/SegmentCest.php b/tests/unit/Models/SegmentCest.php index 6fa9c755ea..3828e650ab 100644 --- a/tests/unit/Models/SegmentCest.php +++ b/tests/unit/Models/SegmentCest.php @@ -23,7 +23,7 @@ class SegmentCest { function itHasToBeValid() { expect($this->saved)->equals(true); $empty_model = Segment::create(); - expect($empty_model->save())->equals(false); + expect($empty_model->save())->notEquals(true); $validations = $empty_model->getValidationErrors(); expect(count($validations))->equals(2); } diff --git a/tests/unit/Models/SettingCest.php b/tests/unit/Models/SettingCest.php index d4e8de8f10..55f82a22bc 100644 --- a/tests/unit/Models/SettingCest.php +++ b/tests/unit/Models/SettingCest.php @@ -21,7 +21,7 @@ class SettingCest { function itHasToBeValid() { expect($this->result)->equals(true); $empty_model = Setting::create(); - expect($empty_model->save())->equals(false); + expect($empty_model->save())->notEquals(true); $validations = $empty_model->getValidationErrors(); expect(count($validations))->equals(4); } diff --git a/tests/unit/Models/SubscriberCest.php b/tests/unit/Models/SubscriberCest.php index 674e1c83ea..6edf90bcda 100644 --- a/tests/unit/Models/SubscriberCest.php +++ b/tests/unit/Models/SubscriberCest.php @@ -50,7 +50,7 @@ class SubscriberCest { $conflict_subscriber = Subscriber::create(); $conflict_subscriber->hydrate($this->data); $saved = $conflict_subscriber->save(); - expect($saved)->equals(false); + expect($saved)->notEquals(true); } function itHasAStatus() {