Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove unnecessary custom CSS, change defualt form padding [MAILPOET-2869]

Browse Source
This commit is contained in:
wxa
2020-05-19 19:39:54 +03:00
committed by Veljko V
parent 9604172cbd
commit e9bbfbee46
4 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
assets/js/src/form_editor/components/form_settings/styles_settings_panel.jsx
View File

@ -101,12 +101,12 @@ const BasicSettingsPanel = ({ onToggle, isOpened }) => {
/> />
<RangeControl <RangeControl
label={MailPoet.I18n.t('formSettingsFormPadding')} label={MailPoet.I18n.t('formSettingsFormPadding')}
value={settings.formPadding !== undefined ? settings.formPadding : 10} value={settings.formPadding !== undefined ? settings.formPadding : 20}
min={0} min={0}
max={40} max={40}
allowReset allowReset
onChange={(value) => { onChange={(value) => {
updateStyles('formPadding', value !== undefined ? value : 10); updateStyles('formPadding', value !== undefined ? value : 20);
}} }}
/> />
</div> </div>

2
assets/js/src/form_editor/store/map_form_data_after_loading.jsx
View File

@ -20,7 +20,7 @@ export default function mapFormDataAfterLoading(data) {
slideInFormPosition: data.settings.slide_in_form_position, slideInFormPosition: data.settings.slide_in_form_position,
borderRadius: asNum(data.settings.border_radius), borderRadius: asNum(data.settings.border_radius),
borderSize: asNum(data.settings.border_size), borderSize: asNum(data.settings.border_size),
formPadding: data.settings.form_padding ? asNum(data.settings.form_padding) : 10, formPadding: data.settings.form_padding ? asNum(data.settings.form_padding) : 20,
inputPadding: data.settings.input_padding ? asNum(data.settings.input_padding) : 5, inputPadding: data.settings.input_padding ? asNum(data.settings.input_padding) : 5,
borderColor: data.settings.border_color, borderColor: data.settings.border_color,
backgroundImageUrl: data.settings.background_image_url, backgroundImageUrl: data.settings.background_image_url,

1
lib/Form/Util/Styles.php
View File

@ -8,7 +8,6 @@ class Styles {
private $defaultStyles = <<<EOL private $defaultStyles = <<<EOL
/* form */ /* form */
.mailpoet_form { .mailpoet_form {
padding: 20px;
} }
/* columns */ /* columns */

2
tests/javascript/form_editor/store/map_form_data_after_loading.spec.js
View File

@ -60,7 +60,7 @@ describe('Form Data Load Mapper', () => {
}); });
it('Sets default paddings', () => { it('Sets default paddings', () => {
expect(map(data).settings).to.have.property('formPadding', 10); expect(map(data).settings).to.have.property('formPadding', 20);
expect(map(data).settings).to.have.property('inputPadding', 5); expect(map(data).settings).to.have.property('inputPadding', 5);
}); });