Rename mainSidebarEmailTab constant to mainSidebarDocumentTab

The email name was misleading because in the template mode we want to show Template.
[MAILPOET-6336]
This commit is contained in:
Rostislav Wolny
2024-12-02 16:05:58 +01:00
committed by Rostislav Wolný
parent ab00d505b9
commit ed8d64816c
5 changed files with 11 additions and 11 deletions

View File

@@ -12,12 +12,12 @@ import { Tabs } from '../../private-apis';
/** /**
* Internal dependencies * Internal dependencies
*/ */
import { mainSidebarEmailTab, mainSidebarBlockTab } from '../../store'; import { mainSidebarDocumentTab, mainSidebarBlockTab } from '../../store';
export function HeaderTabs( _, ref ) { export function HeaderTabs( _, ref ) {
return ( return (
<Tabs.TabList ref={ ref }> <Tabs.TabList ref={ ref }>
<Tabs.Tab tabId={ mainSidebarEmailTab }> <Tabs.Tab tabId={ mainSidebarDocumentTab }>
{ __( 'Email', 'mailpoet' ) } { __( 'Email', 'mailpoet' ) }
</Tabs.Tab> </Tabs.Tab>
<Tabs.Tab tabId={ mainSidebarBlockTab }>{ __( 'Block' ) }</Tabs.Tab> <Tabs.Tab tabId={ mainSidebarBlockTab }>{ __( 'Block' ) }</Tabs.Tab>

View File

@@ -21,7 +21,7 @@ import { Tabs } from '../../private-apis';
*/ */
import { import {
storeName, storeName,
mainSidebarEmailTab, mainSidebarDocumentTab,
mainSidebarBlockTab, mainSidebarBlockTab,
mainSidebarId, mainSidebarId,
} from '../../store'; } from '../../store';
@@ -58,7 +58,7 @@ function SidebarContent( props: Props ) {
{ ...props } { ...props }
> >
<Tabs.Context.Provider value={ tabsContextValue }> <Tabs.Context.Provider value={ tabsContextValue }>
<Tabs.TabPanel tabId={ mainSidebarEmailTab }> <Tabs.TabPanel tabId={ mainSidebarDocumentTab }>
{ editorMode === 'template' ? ( { editorMode === 'template' ? (
<TemplateSettings /> <TemplateSettings />
) : ( ) : (
@@ -89,13 +89,13 @@ export function Sidebar( props: Props ) {
if ( selectedBlockId ) { if ( selectedBlockId ) {
void toggleSettingsSidebarActiveTab( mainSidebarBlockTab ); void toggleSettingsSidebarActiveTab( mainSidebarBlockTab );
} else { } else {
void toggleSettingsSidebarActiveTab( mainSidebarEmailTab ); void toggleSettingsSidebarActiveTab( mainSidebarDocumentTab );
} }
}, [ selectedBlockId, toggleSettingsSidebarActiveTab ] ); }, [ selectedBlockId, toggleSettingsSidebarActiveTab ] );
return ( return (
<Tabs <Tabs
selectedTabId={ activeTab || mainSidebarEmailTab } selectedTabId={ activeTab || mainSidebarDocumentTab }
onSelect={ ( key ) => onSelect={ ( key ) =>
toggleSettingsSidebarActiveTab( key as string ) toggleSettingsSidebarActiveTab( key as string )
} }

View File

@@ -6,7 +6,7 @@ import { store as noticesStore } from '@wordpress/notices';
import { store as editorStore } from '@wordpress/editor'; import { store as editorStore } from '@wordpress/editor';
import { __ } from '@wordpress/i18n'; import { __ } from '@wordpress/i18n';
import { apiFetch } from '@wordpress/data-controls'; import { apiFetch } from '@wordpress/data-controls';
import { storeName, mainSidebarEmailTab } from './constants'; import { storeName, mainSidebarDocumentTab } from './constants';
import { SendingPreviewStatus, State, Feature, EmailTheme } from './types'; import { SendingPreviewStatus, State, Feature, EmailTheme } from './types';
export const toggleFeature = export const toggleFeature =
@@ -34,7 +34,7 @@ export function updateSendPreviewEmail( toEmail: string ) {
} }
export const openSidebar = export const openSidebar =
( key = mainSidebarEmailTab ) => ( key = mainSidebarDocumentTab ) =>
( { registry } ): unknown => ( { registry } ): unknown =>
registry registry
.dispatch( interfaceStore ) .dispatch( interfaceStore )

View File

@@ -1,6 +1,6 @@
export const storeName = 'email-editor/editor'; export const storeName = 'email-editor/editor';
export const mainSidebarId = 'email-editor/editor/main'; export const mainSidebarId = 'email-editor/editor/main';
export const mainSidebarEmailTab = 'email'; export const mainSidebarDocumentTab = 'document';
export const mainSidebarBlockTab = 'block'; export const mainSidebarBlockTab = 'block';
export const stylesSidebarId = 'email-editor/editor/styles'; export const stylesSidebarId = 'email-editor/editor/styles';

View File

@@ -1,4 +1,4 @@
import { mainSidebarEmailTab } from './constants'; import { mainSidebarDocumentTab } from './constants';
import { State } from './types'; import { State } from './types';
import { import {
getEditorSettings, getEditorSettings,
@@ -19,7 +19,7 @@ export function getInitialState(): State {
isOpened: false, isOpened: false,
}, },
settingsSidebar: { settingsSidebar: {
activeTab: mainSidebarEmailTab, activeTab: mainSidebarDocumentTab,
}, },
postId, postId,
editorSettings: getEditorSettings(), editorSettings: getEditorSettings(),