From eda7a74f255a80fa93e39c95a03db38dfaf6d956 Mon Sep 17 00:00:00 2001 From: Pavel Dohnal Date: Mon, 8 Nov 2021 14:38:32 +0100 Subject: [PATCH] Remove the http client from constructor [MAILPOET-3807] --- tasks/release/TranslationsController.php | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/tasks/release/TranslationsController.php b/tasks/release/TranslationsController.php index dc1a3872a5..dcf02a26d9 100644 --- a/tasks/release/TranslationsController.php +++ b/tasks/release/TranslationsController.php @@ -5,21 +5,13 @@ namespace MailPoetTasks\Release; use GuzzleHttp\Client; class TranslationsController { - private const API_BASE_URI = 'https://translate.wordpress.com/api/import-transifex/'; + private const API_IMPORT_BASE_URI = 'https://translate.wordpress.com/api/import-transifex/'; - /** @var Client */ - private $httpClient; - - public function __construct( - $project = 'mailpoet' - ) { - $this->httpClient = new Client([ - 'base_uri' => self::API_BASE_URI . $project . '/', + public function importTransifex(string $version, $project = 'mailpoet'): array { + $httpClient = new Client([ + 'base_uri' => self::API_IMPORT_BASE_URI . $project . '/', ]); - } - - public function importTransifex(string $version): array { - $response = $this->httpClient->post($version); + $response = $httpClient->post($version); $response->getStatusCode(); if ($response->getStatusCode() !== 200) { return [ @@ -36,4 +28,8 @@ class TranslationsController { } return $result; } + + public function checkIfTranslationsAreReady(string $version): bool { + return true; + } }