diff --git a/mailpoet/lib/Newsletter/Shortcodes/Shortcodes.php b/mailpoet/lib/Newsletter/Shortcodes/Shortcodes.php index e45ffadfd0..d9505682fd 100644 --- a/mailpoet/lib/Newsletter/Shortcodes/Shortcodes.php +++ b/mailpoet/lib/Newsletter/Shortcodes/Shortcodes.php @@ -151,7 +151,7 @@ class Shortcodes { ''; $shortcodeDetails['action_argument_value'] = !empty($shortcodeDetails['argument_value']) ? $shortcodeDetails['argument_value'] : - false; + ''; $shortcodeDetails['arguments'] = !empty($shortcodeDetails['arguments']) ? $shortcodeDetails['arguments'] : []; diff --git a/mailpoet/tests/integration/Newsletter/ShortcodesTest.php b/mailpoet/tests/integration/Newsletter/ShortcodesTest.php index f25bc32399..f6dad3a1e5 100644 --- a/mailpoet/tests/integration/Newsletter/ShortcodesTest.php +++ b/mailpoet/tests/integration/Newsletter/ShortcodesTest.php @@ -372,6 +372,15 @@ class ShortcodesTest extends \MailPoetTest { } } + public function testItCanProcessShortcodeWithEmptyDefault() { + $shortcode = '[subscriber:lastname | default:]'; + $shortcodesObject = $this->shortcodesObject; + $subscriberWithoutLastname = new SubscriberEntity(); + $shortcodesObject->setSubscriber($subscriberWithoutLastname); + $result = $shortcodesObject->process([$shortcode]); + expect($result[0])->equals(''); + } + public function testItCanProcessCustomLinkShortcodes() { $shortcodesObject = $this->shortcodesObject; $shortcodesObject->setWpUserPreview(false);