Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Use better name for the method that updates api keys states

Browse Source 
[MAILPOET-5191]
This commit is contained in:
Rostislav Wolny
2023-05-01 17:10:58 +02:00
committed by Veljko V
parent f4ae6e0f00
commit edc4ab4f52
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mailpoet/lib/API/JSON/v1/Settings.php
View File

@@ -150,7 +150,7 @@ class Settings extends APIEndpoint {
// when pending approval, leave this to cron / Key Activation tab logic // when pending approval, leave this to cron / Key Activation tab logic
if (!$this->servicesChecker->isMailPoetAPIKeyPendingApproval()) { if (!$this->servicesChecker->isMailPoetAPIKeyPendingApproval()) {
$this->settingsChangeHandler->updateBridge($settings); $this->settingsChangeHandler->updateApiKeyState($settings);
} }
$meta = $this->authorizedEmailsController->onSettingsSave($settings); $meta = $this->authorizedEmailsController->onSettingsSave($settings);

2
mailpoet/lib/Settings/SettingsChangeHandler.php
View File

@@ -91,7 +91,7 @@ class SettingsChangeHandler {
return $task; return $task;
} }
public function updateBridge($settings) { public function updateApiKeyState($settings) {
$apiKey = $settings[Mailer::MAILER_CONFIG_SETTING_NAME]['mailpoet_api_key'] ?? null; $apiKey = $settings[Mailer::MAILER_CONFIG_SETTING_NAME]['mailpoet_api_key'] ?? null;
$premiumKey = $settings['premium']['premium_key'] ?? null; $premiumKey = $settings['premium']['premium_key'] ?? null;
if (!empty($apiKey)) { if (!empty($apiKey)) {

2
mailpoet/tests/integration/Settings/SettingsChangeHandlerTest.php
View File

@@ -122,7 +122,7 @@ class SettingsChangeHandlerTest extends \MailPoetTest {
'subscribersCountReporter' => $countReporterMock, 'subscribersCountReporter' => $countReporterMock,
]); ]);
$changeHandler->updateBridge($settings); $changeHandler->updateApiKeyState($settings);
} }
private function getScheduledTaskByType(string $type): ?ScheduledTaskEntity { private function getScheduledTaskByType(string $type): ?ScheduledTaskEntity {