From edd3e7da791e69af7c3feec4648a610f0ba1b814 Mon Sep 17 00:00:00 2001 From: Pavel Dohnal Date: Wed, 3 Jun 2020 11:26:29 +0200 Subject: [PATCH] Remove padding on mobile [MAILPOET-2924] --- lib/Form/Util/Styles.php | 10 +++++++++- tests/unit/Form/Util/StylesTest.php | 7 +++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/lib/Form/Util/Styles.php b/lib/Form/Util/Styles.php index a2881bc2d0..00ca0ba37a 100644 --- a/lib/Form/Util/Styles.php +++ b/lib/Form/Util/Styles.php @@ -172,7 +172,15 @@ EOL; // Form element styles $formStyles = []; if (isset($formSettings['form_padding'])) { - $formStyles[] = 'padding: ' . $formSettings['form_padding'] . 'px'; + if (in_array( + $displayType, + [FormEntity::DISPLAY_TYPE_POPUP, FormEntity::DISPLAY_TYPE_FIXED_BAR, FormEntity::DISPLAY_TYPE_SLIDE_IN] + )) { + $padding = $formSettings['form_padding']; + $media .= " @media (min-width: 500px) {{$selector} {padding: {$padding}px;}} "; + } else { + $formStyles[] = 'padding: ' . $formSettings['form_padding'] . 'px'; + } } $formElementStyles = ''; if ($formStyles) { diff --git a/tests/unit/Form/Util/StylesTest.php b/tests/unit/Form/Util/StylesTest.php index 6951b42b47..4542550bdc 100644 --- a/tests/unit/Form/Util/StylesTest.php +++ b/tests/unit/Form/Util/StylesTest.php @@ -68,6 +68,13 @@ class StylesTest extends \MailPoetUnitTest { expect($styles)->contains('form.mailpoet_form {padding: 22px'); } + public function testItShouldNotRenderPaddingForMobile() { + $form = Fixtures::get('simple_form_body'); + $form['settings'] = ['form_padding' => '22']; + $styles = $this->styles->renderFormSettingsStyles($form, '#prefix', FormEntity::DISPLAY_TYPE_SLIDE_IN); + expect($styles)->contains('min-width: 500px) {#prefix {padding: 22px;'); + } + public function testItShouldRenderAlignment() { $form = Fixtures::get('simple_form_body'); $form['settings'] = ['alignment' => 'right'];