Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Refactor ViewInBrowserControllerTest to use Doctrine instead of Sending

Browse Source 
[MAILPOET-5684]
This commit is contained in:
Rodrigo Primo
2023-11-28 12:37:29 -03:00
committed by Aschepikov
parent 6f5e22c54c
commit ee04736a88
1 changed files with 25 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
mailpoet/tests/integration/Newsletter/ViewInBrowser/ViewInBrowserControllerTest.php
View File

@ -3,16 +3,20 @@
namespace MailPoet\Newsletter\ViewInBrowser; namespace MailPoet\Newsletter\ViewInBrowser;
use Codeception\Stub\Expected; use Codeception\Stub\Expected;
use MailPoet\Cron\Workers\SendingQueue\SendingQueue;
use MailPoet\Entities\NewsletterEntity; use MailPoet\Entities\NewsletterEntity;
use MailPoet\Entities\ScheduledTaskEntity;
use MailPoet\Entities\SendingQueueEntity; use MailPoet\Entities\SendingQueueEntity;
use MailPoet\Entities\SubscriberEntity; use MailPoet\Entities\SubscriberEntity;
use MailPoet\Newsletter\NewslettersRepository; use MailPoet\Newsletter\NewslettersRepository;
use MailPoet\Newsletter\Sending\ScheduledTaskSubscribersRepository;
use MailPoet\Newsletter\Sending\SendingQueuesRepository; use MailPoet\Newsletter\Sending\SendingQueuesRepository;
use MailPoet\Newsletter\Url; use MailPoet\Newsletter\Url;
use MailPoet\Subscribers\LinkTokens; use MailPoet\Subscribers\LinkTokens;
use MailPoet\Subscribers\SubscribersRepository; use MailPoet\Subscribers\SubscribersRepository;
use MailPoet\Tasks\Sending as SendingTask;
use MailPoet\Test\DataFactories\Newsletter; use MailPoet\Test\DataFactories\Newsletter;
use MailPoet\Test\DataFactories\ScheduledTask as ScheduledTaskFactory;
use MailPoet\Test\DataFactories\SendingQueue as SendingQueueFactory;
use MailPoet\Util\Security; use MailPoet\Util\Security;
class ViewInBrowserControllerTest extends \MailPoetTest { class ViewInBrowserControllerTest extends \MailPoetTest {
@ -28,9 +32,6 @@ class ViewInBrowserControllerTest extends \MailPoetTest {
/** @var SubscriberEntity */ /** @var SubscriberEntity */
private $subscriber; private $subscriber;
/** @var SendingTask */
private $sendingTask;
/** @var mixed[] */ /** @var mixed[] */
private $browserPreviewData; private $browserPreviewData;
@ -43,6 +44,15 @@ class ViewInBrowserControllerTest extends \MailPoetTest {
/** @var Url */ /** @var Url */
private $newsletterUrl; private $newsletterUrl;
/** @var ScheduledTaskSubscribersRepository */
private $scheduledTaskSubscribersRepository;
/** @var ScheduledTaskEntity */
private $scheduledTask;
/** @var SendingQueueEntity */
private $sendingQueue;
public function _before() { public function _before() {
// instantiate class // instantiate class
$this->viewInBrowserController = $this->diContainer->get(ViewInBrowserController::class); $this->viewInBrowserController = $this->diContainer->get(ViewInBrowserController::class);
@ -50,6 +60,7 @@ class ViewInBrowserControllerTest extends \MailPoetTest {
$this->subscribersRepository = $this->diContainer->get(SubscribersRepository::class); $this->subscribersRepository = $this->diContainer->get(SubscribersRepository::class);
$this->sendingQueuesRepository = $this->diContainer->get(SendingQueuesRepository::class); $this->sendingQueuesRepository = $this->diContainer->get(SendingQueuesRepository::class);
$this->newslettersRepository = $this->diContainer->get(NewslettersRepository::class); $this->newslettersRepository = $this->diContainer->get(NewslettersRepository::class);
$this->scheduledTaskSubscribersRepository = $this->diContainer->get(ScheduledTaskSubscribersRepository::class);
$this->newsletterUrl = $this->diContainer->get(Url::class); $this->newsletterUrl = $this->diContainer->get(Url::class);
// create newsletter // create newsletter
@ -66,16 +77,14 @@ class ViewInBrowserControllerTest extends \MailPoetTest {
$this->subscribersRepository->flush(); $this->subscribersRepository->flush();
$this->subscriber = $subscriber; $this->subscriber = $subscriber;
// create task & queue $this->scheduledTask = (new ScheduledTaskFactory())->create(SendingQueue::TASK_TYPE, null);
$sendingTask = SendingTask::create(); $this->sendingQueue = (new SendingQueueFactory())->create($this->scheduledTask, $newsletter);
$sendingTask->newsletterId = $newsletter->getId(); $this->scheduledTaskSubscribersRepository->setSubscribers($this->scheduledTask, [$subscriber->getId()]);
$sendingTask->setSubscribers([$subscriber->getId()]); $this->scheduledTaskSubscribersRepository->updateProcessedSubscribers($this->scheduledTask, [(int)$subscriber->getId()]);
$sendingTask->updateProcessedSubscribers([$subscriber->getId()]);
$this->sendingTask = $sendingTask->save();
// build browser preview data // build browser preview data
$this->browserPreviewData = [ $this->browserPreviewData = [
'queue_id' => $sendingTask->queue()->id, 'queue_id' => $this->sendingQueue->getId(),
'subscriber_id' => $subscriber->getId(), 'subscriber_id' => $subscriber->getId(),
'newsletter_id' => $newsletter->getId(), 'newsletter_id' => $newsletter->getId(),
'newsletter_hash' => $newsletter->getHash(), 'newsletter_hash' => $newsletter->getHash(),
@ -120,10 +129,8 @@ class ViewInBrowserControllerTest extends \MailPoetTest {
public function testItThrowsWhenSubscriberIsNotOnProcessedList() { public function testItThrowsWhenSubscriberIsNotOnProcessedList() {
$data = $this->browserPreviewData; $data = $this->browserPreviewData;
$sendingTask = $this->sendingTask; $this->scheduledTaskSubscribersRepository->setSubscribers($this->scheduledTask, []);
$sendingTask->setSubscribers([]); $this->scheduledTaskSubscribersRepository->updateProcessedSubscribers($this->scheduledTask, []);
$sendingTask->updateProcessedSubscribers([]);
$sendingTask->save();
$this->expectViewThrowsExceptionWithMessage($this->viewInBrowserController, $data, 'Subscriber did not receive the newsletter yet'); $this->expectViewThrowsExceptionWithMessage($this->viewInBrowserController, $data, 'Subscriber did not receive the newsletter yet');
} }
@ -171,14 +178,14 @@ class ViewInBrowserControllerTest extends \MailPoetTest {
'render' => Expected::once(function (bool $isPreview, NewsletterEntity $newsletter, SubscriberEntity $subscriber = null, SendingQueueEntity $queue = null) { 'render' => Expected::once(function (bool $isPreview, NewsletterEntity $newsletter, SubscriberEntity $subscriber = null, SendingQueueEntity $queue = null) {
$this->assertNotNull($queue); // PHPStan $this->assertNotNull($queue); // PHPStan
verify($queue)->notNull(); verify($queue)->notNull();
verify($queue->getId())->equals($this->sendingTask->id); verify($queue->getId())->equals($this->sendingQueue->getId());
}), }),
]); ]);
$viewInBrowserController = $this->createController($viewInBrowserRenderer); $viewInBrowserController = $this->createController($viewInBrowserRenderer);
$data = $this->browserPreviewData; $data = $this->browserPreviewData;
$data['queueId'] = $this->sendingTask->queue()->id; $data['queueId'] = $this->sendingQueue->getId();
$viewInBrowserController->view($data); $viewInBrowserController->view($data);
} }
@ -187,7 +194,7 @@ class ViewInBrowserControllerTest extends \MailPoetTest {
'render' => Expected::once(function (bool $isPreview, NewsletterEntity $newsletter, SubscriberEntity $subscriber = null, SendingQueueEntity $queue = null) { 'render' => Expected::once(function (bool $isPreview, NewsletterEntity $newsletter, SubscriberEntity $subscriber = null, SendingQueueEntity $queue = null) {
$this->assertNotNull($queue); // PHPStan $this->assertNotNull($queue); // PHPStan
verify($queue)->notNull(); verify($queue)->notNull();
verify($queue->getId())->equals($this->sendingTask->queue()->id); verify($queue->getId())->equals($this->sendingQueue->getId());
}), }),
]); ]);