From ef009d0400e007de64beb9ddf4e42c71ac4aa493 Mon Sep 17 00:00:00 2001 From: Oluwaseun Olorunsola Date: Tue, 12 Nov 2024 13:13:49 +0100 Subject: [PATCH] Move InserterSidebar state from email editor store to @wordpress/editor store MAILPOET-6303 --- packages/js/email-editor/src/store/actions.ts | 11 ++++++----- packages/js/email-editor/src/store/reducer.ts | 12 ------------ packages/js/email-editor/src/store/selectors.ts | 8 +++++--- 3 files changed, 11 insertions(+), 20 deletions(-) diff --git a/packages/js/email-editor/src/store/actions.ts b/packages/js/email-editor/src/store/actions.ts index b8cfa7e23d..0ead0ffcda 100644 --- a/packages/js/email-editor/src/store/actions.ts +++ b/packages/js/email-editor/src/store/actions.ts @@ -14,11 +14,12 @@ export const toggleFeature = ( { registry } ): unknown => registry.dispatch( preferencesStore ).toggle( storeName, feature ); -export function toggleInserterSidebar() { - return { - type: 'TOGGLE_INSERTER_SIDEBAR', - } as const; -} +export const toggleInserterSidebar = + () => + ( { registry } ) => { + const status = registry.select( editorStore ).isInserterOpened(); + void registry.dispatch( editorStore ).setIsInserterOpened( ! status ); + }; export function toggleListviewSidebar() { return { diff --git a/packages/js/email-editor/src/store/reducer.ts b/packages/js/email-editor/src/store/reducer.ts index 68be50a224..3d4b7255cc 100644 --- a/packages/js/email-editor/src/store/reducer.ts +++ b/packages/js/email-editor/src/store/reducer.ts @@ -2,18 +2,6 @@ import { State } from './types'; export function reducer( state: State, action ): State { switch ( action.type ) { - case 'TOGGLE_INSERTER_SIDEBAR': - return { - ...state, - inserterSidebar: { - ...state.inserterSidebar, - isOpened: ! state.inserterSidebar.isOpened, - }, - listviewSidebar: { - ...state.listviewSidebar, - isOpened: false, - }, - }; case 'TOGGLE_LISTVIEW_SIDEBAR': return { ...state, diff --git a/packages/js/email-editor/src/store/selectors.ts b/packages/js/email-editor/src/store/selectors.ts index f27b96f6d5..50aa2dd3d8 100644 --- a/packages/js/email-editor/src/store/selectors.ts +++ b/packages/js/email-editor/src/store/selectors.ts @@ -231,9 +231,11 @@ export function getEmailPostId( state: State ): number { return state.postId; } -export function isInserterSidebarOpened( state: State ): boolean { - return state.inserterSidebar.isOpened; -} +export const isInserterSidebarOpened = createRegistrySelector( + ( select ) => () => + // @ts-expect-error isInserterOpened is missing in types. + select( editorStore ).isInserterOpened() as boolean +); export function isListviewSidebarOpened( state: State ): boolean { return state.listviewSidebar.isOpened;