From f0fa9bee2e8034c89b8b10c7305c2d364cdc40a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Jakes=CC=8C?= Date: Wed, 2 Oct 2019 11:47:17 +0200 Subject: [PATCH] Fix WooCommerce test stubs to follow Code Sniffer rules [MAILPOET-2382] --- .../WooCommerce/Events/FirstPurchaseTest.php | 12 +++--- .../Events/PurchasedProductTest.php | 22 ++++++----- .../WooCommerce/WooCommerceStub.php | 38 ------------------- .../WooCommerceStubs/ItemDetails.php | 9 +++++ .../WooCommerceStubs/OrderDetails.php | 37 ++++++++++++++++++ 5 files changed, 64 insertions(+), 54 deletions(-) delete mode 100644 tests/integration/AutomaticEmails/WooCommerce/WooCommerceStub.php create mode 100644 tests/integration/AutomaticEmails/WooCommerce/WooCommerceStubs/ItemDetails.php create mode 100644 tests/integration/AutomaticEmails/WooCommerce/WooCommerceStubs/OrderDetails.php diff --git a/tests/integration/AutomaticEmails/WooCommerce/Events/FirstPurchaseTest.php b/tests/integration/AutomaticEmails/WooCommerce/Events/FirstPurchaseTest.php index bce861fa29..7e9fb09f18 100644 --- a/tests/integration/AutomaticEmails/WooCommerce/Events/FirstPurchaseTest.php +++ b/tests/integration/AutomaticEmails/WooCommerce/Events/FirstPurchaseTest.php @@ -7,7 +7,6 @@ use Codeception\Stub\Expected; use Codeception\Util\Fixtures; use MailPoet\AutomaticEmails\WooCommerce\Events\FirstPurchase; use MailPoet\AutomaticEmails\WooCommerce\Helper as WCPremiumHelper; -use MailPoet\AutomaticEmails\WooCommerce\OrderDetails; use MailPoet\AutomaticEmails\WooCommerce\WooCommerce; use MailPoet\Models\Newsletter; use MailPoet\Models\NewsletterOption; @@ -17,10 +16,11 @@ use MailPoet\Models\ScheduledTaskSubscriber; use MailPoet\Models\SendingQueue; use MailPoet\Models\Subscriber; use MailPoet\Tasks\Sending; +use MailPoet\Test\AutomaticEmails\WooCommerce\WooCommerceStubs\OrderDetails; use MailPoet\WooCommerce\Helper as WCHelper; use MailPoet\WP\Functions as WPFunctions; -require_once(__DIR__ . '/../WooCommerceStub.php'); +require_once __DIR__ . '/../WooCommerceStubs/OrderDetails.php'; class FirstPurchaseTest extends \MailPoetTest { function _before() { @@ -134,7 +134,7 @@ class FirstPurchaseTest extends \MailPoetTest { function testItDoesNotScheduleEmailWhenCustomerEmailIsEmpty() { $order_details = Stub::make( - new \WooCommerceStub\OrderDetails(), + new OrderDetails(), [ 'get_billing_email' => Expected::once(), ], @@ -149,7 +149,7 @@ class FirstPurchaseTest extends \MailPoetTest { } function testItDoesNotScheduleEmailWhenItIsNotCustomersFirstPurchase() { - $order_details = Stub::make(new \WooCommerceStub\OrderDetails(), ['get_billing_email' => 'test@example.com']); + $order_details = Stub::make(new OrderDetails(), ['get_billing_email' => 'test@example.com']); $helper = Stub::make(WCHelper::class, [ 'wcGetOrder' => $order_details, ]); @@ -164,7 +164,7 @@ class FirstPurchaseTest extends \MailPoetTest { function testItDoesNotScheduleEmailWhenCustomerIsNotAWCSegmentSubscriber() { $date_created = new \DateTime('2018-12-12'); $order_details = Stub::make( - new \WooCommerceStub\OrderDetails(), + new OrderDetails(), [ 'get_billing_email' => 'test@example.com', 'get_date_created' => Expected::once(function() use ($date_created) { @@ -235,7 +235,7 @@ class FirstPurchaseTest extends \MailPoetTest { $helper = Stub::make(WCHelper::class, [ 'wcGetOrder' => function($order_id) use ($customer_email, $date_created) { $order_details = Stub::construct( - new \WooCommerceStub\OrderDetails(), + new OrderDetails(), [$order_id], [ 'get_billing_email' => $customer_email, diff --git a/tests/integration/AutomaticEmails/WooCommerce/Events/PurchasedProductTest.php b/tests/integration/AutomaticEmails/WooCommerce/Events/PurchasedProductTest.php index 0a27b84d79..cae359ba1a 100644 --- a/tests/integration/AutomaticEmails/WooCommerce/Events/PurchasedProductTest.php +++ b/tests/integration/AutomaticEmails/WooCommerce/Events/PurchasedProductTest.php @@ -16,10 +16,12 @@ use MailPoet\Models\ScheduledTaskSubscriber; use MailPoet\Models\SendingQueue; use MailPoet\Models\Subscriber; use MailPoet\Tasks\Sending; +use MailPoet\Test\AutomaticEmails\WooCommerce\WooCommerceStubs\ItemDetails; +use MailPoet\Test\AutomaticEmails\WooCommerce\WooCommerceStubs\OrderDetails; use MailPoet\WooCommerce\Helper as WCHelper; use MailPoet\WP\Functions as WPFunctions; -require_once(__DIR__ . '/../WooCommerceStub.php'); +require_once __DIR__ . '/../WooCommerceStubs/ItemDetails.php'; class PurchasedProductTest extends \MailPoetTest { function _before() { @@ -44,7 +46,7 @@ class PurchasedProductTest extends \MailPoetTest { function testItDoesNotScheduleEmailWhenCustomerEmailIsEmpty() { $order_details = Stub::make( - new \WooCommerceStub\OrderDetails(), + new OrderDetails(), [ 'get_billing_email' => Expected::once(), ], @@ -61,13 +63,13 @@ class PurchasedProductTest extends \MailPoetTest { function testItDoesNotScheduleEmailWhenCustomerIsNotAWCSegmentSubscriber() { $order_details = Stub::make( - new \WooCommerceStub\OrderDetails(), + new OrderDetails(), [ 'get_billing_email' => 'test@example.com', 'get_items' => function() { return [ Stub::make( - new \WooCommerceStub\ItemDetails(), + new ItemDetails(), [ 'get_product_id' => 12, ] @@ -124,19 +126,19 @@ class PurchasedProductTest extends \MailPoetTest { $subscriber->save(); $order_details = Stub::make( - new \WooCommerceStub\OrderDetails(), + new OrderDetails(), [ 'get_billing_email' => 'test@example.com', 'get_items' => function() use ($incorrect_product_ids) { return [ Stub::make( - new \WooCommerceStub\ItemDetails(), + new ItemDetails(), [ 'get_product_id' => $incorrect_product_ids[0], ] ), Stub::make( - new \WooCommerceStub\ItemDetails(), + new ItemDetails(), [ 'get_product_id' => $incorrect_product_ids[1], ] @@ -202,19 +204,19 @@ class PurchasedProductTest extends \MailPoetTest { $subscriber->save(); $order_details = Stub::make( - new \WooCommerceStub\OrderDetails(), + new OrderDetails(), [ 'get_billing_email' => 'test@example.com', 'get_items' => function() use ($incorrect_product_id, $product_id) { return [ Stub::make( - new \WooCommerceStub\ItemDetails(), + new ItemDetails(), [ 'get_product_id' => $incorrect_product_id, ] ), Stub::make( - new \WooCommerceStub\ItemDetails(), + new ItemDetails(), [ 'get_product_id' => $product_id, ] diff --git a/tests/integration/AutomaticEmails/WooCommerce/WooCommerceStub.php b/tests/integration/AutomaticEmails/WooCommerce/WooCommerceStub.php deleted file mode 100644 index e9d5c3b520..0000000000 --- a/tests/integration/AutomaticEmails/WooCommerce/WooCommerceStub.php +++ /dev/null @@ -1,38 +0,0 @@ -order_id = $order_id; - } - - function get_customer_id() { - } - - function get_billing_email() { - } - - function get_date_created() { - } - - function get_id() { - return $this->order_id; - } - - function get_total() { - return $this->total; - } - - function get_items() { - return new ItemDetails(); - } -} - -class ItemDetails { - function get_product_id() { - } -} \ No newline at end of file diff --git a/tests/integration/AutomaticEmails/WooCommerce/WooCommerceStubs/ItemDetails.php b/tests/integration/AutomaticEmails/WooCommerce/WooCommerceStubs/ItemDetails.php new file mode 100644 index 0000000000..f3f913fa62 --- /dev/null +++ b/tests/integration/AutomaticEmails/WooCommerce/WooCommerceStubs/ItemDetails.php @@ -0,0 +1,9 @@ +order_id = $order_id; + } + + function get_customer_id() { + } + + function get_billing_email() { + } + + function get_date_created() { + } + + function get_id() { + return $this->order_id; + } + + function get_total() { + return $this->total; + } + + function get_items() { + return new ItemDetails(); + } +}