Updated shortcodes for unsubscribe/manage/browser links

- fixed all issues in #387 except the custom mailpoet pages

lib/Newsletter/Shortcodes/Shortcodes.php

@@ -9,7 +9,8 @@ class Shortcodes {
   function __construct(
     $rendered_newsletter,
     $newsletter = false,
-    $subscriber = false) {
+    $subscriber = false
+  ) {
     $this->rendered_newsletter = $rendered_newsletter;
     $this->newsletter = $newsletter;
     $this->subscriber = $subscriber;
@@ -29,14 +30,6 @@ class Shortcodes {
           $shortcode_details
         );
 
-        // TODO: discuss renaming "global". It is a reserved name in PHP.
-        if(
-          isset($shortcode_details['type'])
-          && $shortcode_details['type'] === 'global'
-        ) {
-          $shortcode_details['type'] = 'link';
-        }
-
         $shortcode_class =
           __NAMESPACE__ . '\\Categories\\' . ucfirst($shortcode_details['type']);
         if(!class_exists($shortcode_class)) return false;