Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Refactor JiraController instantiation to a method

Browse Source 
[MAILPOET-1883]
This commit is contained in:
Jan Jakeš
2019-04-10 13:13:52 +02:00
committed by wxa
parent 400fb7f559
commit f12cb6d77b
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
RoboFile.php
View File

@ -640,12 +640,7 @@ class RoboFile extends \Robo\Tasks {
public function releasePublishSlack($version = null) {
$this->loadEnv();
$jira_controller = new \MailPoetTasks\Release\JiraController(
getenv('WP_JIRA_TOKEN'),
getenv('WP_JIRA_USER'),
\MailPoetTasks\Release\JiraController::PROJECT_MAILPOET
);
$jira_controller = $this->createJiraController();
$version = $jira_controller->getVersion($version);
$changelog = $this->getChangelogController()->get($version['name']);
@ -662,4 +657,13 @@ class RoboFile extends \Robo\Tasks {
exit(1);
}
}
protected function createJiraController() {
$this->loadEnv();
return new \MailPoetTasks\Release\JiraController(
getenv('WP_JIRA_TOKEN'),
getenv('WP_JIRA_USER'),
\MailPoetTasks\Release\JiraController::PROJECT_MAILPOET
);
}
}