Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Use a better name for method

Browse Source 
[MAILPOET-2439]
This commit is contained in:
Pavel Dohnal
2019-10-29 15:55:57 +01:00
committed by Jack Kitterhing
parent 45eb3d39c2
commit f1934ff880
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Cron/Workers/StatsNotifications/Scheduler.php
View File

@ -92,7 +92,7 @@ class Scheduler {
} }
private function isTaskScheduled($newsletter_id) { private function isTaskScheduled($newsletter_id) {
$existing = $this->repository->findAllForNewsletter($newsletter_id); $existing = $this->repository->findByNewsletterId($newsletter_id);
return count($existing) > 0; return count($existing) > 0;
} }

2
lib/Cron/Workers/StatsNotifications/StatsNotificationsRepository.php
View File

@ -17,7 +17,7 @@ class StatsNotificationsRepository extends Repository {
* @param int $newsletter_id * @param int $newsletter_id
* @return StatsNotificationEntity[] * @return StatsNotificationEntity[]
*/ */
public function findAllForNewsletter($newsletter_id) { public function findByNewsletterId($newsletter_id) {
return $this->doctrine_repository return $this->doctrine_repository
->createQueryBuilder('stn') ->createQueryBuilder('stn')
->join('stn.task', 'tasks') ->join('stn.task', 'tasks')

6
tests/unit/Cron/Workers/StatsNotifications/SchedulerTest.php
View File

@ -68,7 +68,7 @@ class SchedulerTest extends \MailPoetUnitTest {
$this->repository $this->repository
->expects($this->once()) ->expects($this->once())
->method('findAllForNewsletter') ->method('findByNewsletterId')
->with($newsletter_id) ->with($newsletter_id)
->willReturn([]); ->willReturn([]);
@ -108,7 +108,7 @@ class SchedulerTest extends \MailPoetUnitTest {
$this->repository $this->repository
->expects($this->once()) ->expects($this->once())
->method('findAllForNewsletter') ->method('findByNewsletterId')
->with($newsletter_id) ->with($newsletter_id)
->willReturn([]); ->willReturn([]);
@ -230,7 +230,7 @@ class SchedulerTest extends \MailPoetUnitTest {
$this->repository $this->repository
->expects($this->once()) ->expects($this->once())
->method('findAllForNewsletter') ->method('findByNewsletterId')
->with($newsletter_id) ->with($newsletter_id)
->willReturn([new ScheduledTaskEntity()]); ->willReturn([new ScheduledTaskEntity()]);
$this->entityManager $this->entityManager