Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove redundant important from style

Browse Source 
We test stripping redundant from rendered emails. I removed redundant important option.
It is based on this article:
https://www.litmus.com/blog/a-guide-to-bulletproof-buttons-in-email-design/

[MAILPOET-3468]
This commit is contained in:
Jan Lysý
2021-08-03 11:20:49 +02:00
committed by Veljko V
parent 811b25673e
commit f6a881da98
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Newsletter/Renderer/Blocks/Button.php
View File

@@ -8,7 +8,7 @@ use MailPoet\Newsletter\Renderer\StylesHelper;
class Button { class Button {
public function render($element, $columnBaseWidth) { public function render($element, $columnBaseWidth) {
$element['styles']['block']['width'] = $this->calculateWidth($element, $columnBaseWidth); $element['styles']['block']['width'] = $this->calculateWidth($element, $columnBaseWidth);
$styles = 'display:inline-block;-webkit-text-size-adjust:none;mso-hide:all;text-decoration:none !important;text-align:center;' . StylesHelper::getBlockStyles($element, $exclude = ['textAlign']); $styles = 'display:inline-block;-webkit-text-size-adjust:none;mso-hide:all;text-decoration:none;text-align:center;' . StylesHelper::getBlockStyles($element, $exclude = ['textAlign']);
$styles = EHelper::escapeHtmlStyleAttr($styles); $styles = EHelper::escapeHtmlStyleAttr($styles);
$template = ' $template = '
<tr> <tr>

2
tests/unit/Newsletter/Renderer/Blocks/ButtonTest.php
View File

@@ -53,7 +53,7 @@ class ButtonTest extends \MailPoetUnitTest {
</v:roundrect> </v:roundrect>
<![endif]--> <![endif]-->
<!--[if !mso]><!-- --> <!--[if !mso]><!-- -->
<a class="mailpoet_button" href="https://example.com" style="display:inline-block;-webkit-text-size-adjust:none;mso-hide:all;text-decoration:none !important;text-align:center;background-color: #252525;border-color: #363636;border-width: 2px;border-radius: 5px;border-style: solid;width: 156px;line-height: 40px;color: #ffffff;font-family: \'source sans pro\', \'helvetica neue\', helvetica, arial, sans-serif;font-size: 14px;font-weight: bold;"> Button</a> <a class="mailpoet_button" href="https://example.com" style="display:inline-block;-webkit-text-size-adjust:none;mso-hide:all;text-decoration:none;text-align:center;background-color: #252525;border-color: #363636;border-width: 2px;border-radius: 5px;border-style: solid;width: 156px;line-height: 40px;color: #ffffff;font-family: \'source sans pro\', \'helvetica neue\', helvetica, arial, sans-serif;font-size: 14px;font-weight: bold;"> Button</a>
<!--<![endif]--> <!--<![endif]-->
</td> </td>
</tr> </tr>