Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove FormRepository from SettingsController

Browse Source 
[MAILPOET-3643]
This commit is contained in:
Jan Lysý
2021-06-01 20:15:20 +02:00
committed by Veljko V
parent e7a0355ba1
commit f7b77cf75d
8 changed files with 31 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
tests/integration/Settings/SettingsControllerTest.php
View File

@@ -3,9 +3,7 @@
namespace MailPoet\Test\Settings;
use Codeception\Stub;
use MailPoet\Entities\FormEntity;
use MailPoet\Entities\SettingEntity;
use MailPoet\Form\FormsRepository;
use MailPoet\Settings\SettingsController;
use MailPoet\Settings\SettingsRepository;
@@ -14,13 +12,9 @@ class SettingsControllerTest extends \MailPoetTest {
/** @var SettingsController */
private $controller;
/** @var FormsRepository */
private $formsReposittory;
public function _before() {
parent::_before();
$this->controller = $this->diContainer->get(SettingsController::class);
$this->formsReposittory = $this->diContainer->get(FormsRepository::class);
$this->clear();
}
@@ -121,40 +115,8 @@ class SettingsControllerTest extends \MailPoetTest {
$this->assertEquals(true, true);
}
public function testItReturnsCorrectSuccessMessage(): void {
$this->controller->set('signup_confirmation.enabled', 1);
expect($this->controller->getDefaultSuccessMessage())->equals(__('Check your inbox or spam folder to confirm your subscription.', 'mailpoet'));
$this->controller->set('signup_confirmation.enabled', 0);
expect($this->controller->getDefaultSuccessMessage())->equals(__('You’ve been successfully subscribed to our newsletter!', 'mailpoet'));
}
public function testItUpdatesSuccessMessagesForForms(): void {
$this->controller->set('signup_confirmation.enabled', 1);
$form = new FormEntity('test form');
$form->setSettings(['success_message' => __('Check your inbox or spam folder to confirm your subscription.', 'mailpoet')]);
$this->entityManager->persist($form);
$this->entityManager->flush();
$this->controller->set('signup_confirmation.enabled', 0);
$this->controller->updateSuccessMessages();
$forms = $this->formsReposittory->findAll();
expect($forms)->count(1);
foreach ($forms as $form) {
expect($form->getSettings()['success_message'] ?? null)->equals(__('You’ve been successfully subscribed to our newsletter!', 'mailpoet'));
}
$this->controller->set('signup_confirmation.enabled', 1);
$this->controller->updateSuccessMessages();
$forms = $this->formsReposittory->findAll();
expect($forms)->count(1);
foreach ($forms as $form) {
expect($form->getSettings()['success_message'] ?? null)->equals(__('Check your inbox or spam folder to confirm your subscription.', 'mailpoet'));
}
}
private function clear() {
$this->truncateEntity(SettingEntity::class);
$this->truncateEntity(FormEntity::class);
}
public function _after() {