Refactor function to a separate file

[MAILPOET-2835]
This commit is contained in:
Pavel Dohnal
2020-04-28 15:42:53 +02:00
committed by Veljko V
parent d7b514d526
commit f9ea393b07
6 changed files with 33 additions and 10 deletions

View File

@ -224,7 +224,7 @@ class RoboFile extends \Robo\Tasks {
}
public function testJavascript($xmlOutputFile = null) {
$command = './node_modules/.bin/mocha --require @babel/register tests/javascript/**/*.spec.js';
$command = './node_modules/.bin/mocha --require tests/javascript/babel_register.js tests/javascript/**/*.spec.js';
if (!empty($xmlOutputFile)) {
$command .= sprintf(

View File

@ -1,11 +1,4 @@
function asNum(num) {
const numI = parseInt(num, 10);
if (Number.isNaN(numI)) {
return undefined;
}
return numI;
}
import asNum from './server_value_as_num';
export default function mapFormDataAfterLoading(data) {
return {

View File

@ -0,0 +1,10 @@
function asNum(num?: string): number | undefined {
const numI = parseInt(num, 10);
if (Number.isNaN(numI)) {
return undefined;
}
return numI;
}
export default asNum;

View File

@ -18,7 +18,7 @@
"autoprefixer": "postcss assets/dist/css/*.css --use autoprefixer --no-map --replace",
"scss": "node-sass assets/css/src/ --output assets/dist/css/ --output-style compact",
"stylelint": "stylelint --fix",
"test": "mocha --require @babel/register tests/javascript/**/*.spec.js",
"test": "mocha --require tests/javascript/babel_register.js tests/javascript/**/*.spec.js",
"check-types": "tsc --noEmit",
"storybook": "start-storybook -s ./ -p 8083",
"build-storybook": "build-storybook"

View File

@ -0,0 +1 @@
require('@babel/register')({ extensions: ['.js', '.jsx', '.ts', '.tsx'] });

View File

@ -0,0 +1,19 @@
import { expect } from 'chai';
import asNum from '../../../../assets/js/src/form_editor/store/server_value_as_num';
describe.only('Server value as num', () => {
it('Converts string to number', () => {
expect(asNum('4')).to.equal(4);
expect(asNum('0')).to.equal(0);
expect(asNum('09')).to.equal(9);
expect(asNum('159')).to.equal(159);
expect(asNum('-159')).to.equal(-159);
});
it('Converts returns undefined', () => {
expect(asNum('xxx')).to.be.undefined;
expect(asNum(null)).to.be.undefined;
expect(asNum(undefined)).to.be.undefined;
});
});