Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add space between for and ‘(‘

Browse Source 
[MAILPOET-1791]
This commit is contained in:
Ján Mikláš
2019-02-13 12:48:07 +01:00
committed by M. Shull
parent b2e5952896
commit fba2914392
20 changed files with 44 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Form/Block/Date.php
View File

@ -142,7 +142,7 @@ class Date extends Base {
// empty value label
$html .= '<option value="">'.__('Month', 'mailpoet').'</option>';
for($i = 1; $i < 13; $i++) {
for ($i = 1; $i < 13; $i++) {
$is_selected = ($i === $block['selected']) ? 'selected="selected"' : '';
$html .= '<option value="'.$i.'" '.$is_selected.'>';
$html .= $month_names[$i - 1];
@ -173,7 +173,7 @@ class Date extends Base {
$html .= '<option value="">'.__('Year', 'mailpoet').'</option>';
// return years as an array
for($i = (int)$block['to']; $i > (int)($block['from'] - 1); $i--) {
for ($i = (int)$block['to']; $i > (int)($block['from'] - 1); $i--) {
$is_selected = ($i === $block['selected']) ? 'selected="selected"' : '';
$html .= '<option value="'.$i.'" '.$is_selected.'>'.$i.'</option>';
}
@ -199,7 +199,7 @@ class Date extends Base {
$html .= '<option value="">'.__('Day', 'mailpoet').'</option>';
// return days as an array
for($i = 1; $i < 32; $i++) {
for ($i = 1; $i < 32; $i++) {
$is_selected = ($i === $block['selected']) ? 'selected="selected"' : '';
$html .= '<option value="'.$i.'" '.$is_selected.'>'.$i.'</option>';
}

2
lib/Mailer/Methods/MailPoet.php
View File

@ -98,7 +98,7 @@ class MailPoet {
};
if(is_array($newsletter) && is_array($subscriber)) {
$body = array();
for($record = 0; $record < count($newsletter); $record++) {
for ($record = 0; $record < count($newsletter); $record++) {
$body[] = $composeBody(
$newsletter[$record],
$this->processSubscriber($subscriber[$record]),

2
lib/Util/DOM.php
View File

@ -11,7 +11,7 @@ class DOM {
*/
static function splitOn(DomNode $bound, DomNode $cut_element) {
$ignore_text_and_comment_nodes = false;
for($parent = $cut_element->parent; $bound != $parent; $parent = $grandparent) {
for ($parent = $cut_element->parent; $bound != $parent; $parent = $grandparent) {
// Clone parent node without children, but with attributes
$parent->after($parent->toString());
$right = $parent->getNextSibling($ignore_text_and_comment_nodes);

2
lib/Util/XLSXWriter.php
View File

@ -440,7 +440,7 @@ class XLSXWriter
public static function xlsCell($row_number, $column_number)
{
$n = $column_number;
for($r = ""; $n >= 0; $n = intval($n / 26) - 1) {
for ($r = ""; $n >= 0; $n = intval($n / 26) - 1) {
$r = chr($n%26 + 0x41) . $r;
}
return $r . ($row_number+1);

2
lib/WP/DateTime.php
View File

@ -67,7 +67,7 @@ class DateTime {
$formatted_time = $start_time;
$timestamp = strtotime($formatted_time);
for($step = 0; $step < $total_steps; $step += 1) {
for ($step = 0; $step < $total_steps; $step += 1) {
$formatted_time = $this->formatTime($timestamp, self::DEFAULT_TIME_FORMAT);
$label_time = $this->formatTime($timestamp);
$steps[$formatted_time] = $label_time;

4
tests/_support/IntegrationTester.php
View File

@ -21,7 +21,7 @@ class IntegrationTester extends \Codeception\Actor {
// generate random users
function generateSubscribers($count, $data = array()) {
for($i = 0; $i < $count; $i++) {
for ($i = 0; $i < $count; $i++) {
$this->generateSubscriber($data);
}
}
@ -51,7 +51,7 @@ class IntegrationTester extends \Codeception\Actor {
// pick first letter in alphabet
$name .= $alphabet{mt_rand(0, strlen($alphabet) - 1)};
for($i = 0; $i < $length; $i++) {
for ($i = 0; $i < $length; $i++) {
$name .= $charset{mt_rand(0, strlen($charset) - 1)};
}

4
tests/_support/UnitTester.php
View File

@ -21,7 +21,7 @@ class UnitTester extends \Codeception\Actor {
// generate random users
function generateSubscribers($count, $data = array()) {
for($i = 0; $i < $count; $i++) {
for ($i = 0; $i < $count; $i++) {
$this->generateSubscriber($data);
}
}
@ -51,7 +51,7 @@ class UnitTester extends \Codeception\Actor {
// pick first letter in alphabet
$name .= $alphabet{mt_rand(0, strlen($alphabet) - 1)};
for($i = 0; $i < $length; $i++) {
for ($i = 0; $i < $length; $i++) {
$name .= $charset{mt_rand(0, strlen($charset) - 1)};
}

2
tests/acceptance/ReinstallFromScratchCest.php
View File

@ -31,7 +31,7 @@ class ReinstallFromScratchCest {
$subscriber = new Subscriber();
$subscriber->create();
// Create few WP users, which should be imported after reinstall
for($i = 0; $i <= 5; $i++) {
for ($i = 0; $i <= 5; $i++) {
wp_create_user('test' . $i, 'password', 'imported' . $i . '@from.wordpress');
}

2
tests/integration/API/JSON/v1/NewslettersTest.php
View File

@ -51,7 +51,7 @@ class NewslettersTest extends \MailPoetTest {
function testItKeepsUnsentNewslettersAtTheTopWhenSortingBySentAtDate() {
$sent_newsletters = array();
for($i = 1; $i <= 3; $i++) {
for ($i = 1; $i <= 3; $i++) {
$sent_newsletters[$i] = Newsletter::create();
$sent_newsletters[$i]->type = Newsletter::TYPE_STANDARD;
$sent_newsletters[$i]->subject = 'Sent newsletter ' . $i;

2
tests/integration/Cron/Workers/SendingQueue/Tasks/NewsletterTest.php
View File

@ -299,7 +299,7 @@ class NewsletterTest extends \MailPoetTest {
}
function testItGetsSegments() {
for($i = 1; $i<=3; $i++) {
for ($i = 1; $i<=3; $i++) {
$newsletter_segment = NewsletterSegment::create();
$newsletter_segment->newsletter_id = $this->newsletter->id;
$newsletter_segment->segment_id = $i;

6
tests/integration/Cron/Workers/SimpleWorkerTest.php
View File

@ -69,7 +69,7 @@ class SimpleWorkerTest extends \MailPoetTest {
}
function testItCanGetABatchOfScheduledTasks() {
for($i = 0; $i < MockSimpleWorker::TASK_BATCH_SIZE + 5; $i += 1) {
for ($i = 0; $i < MockSimpleWorker::TASK_BATCH_SIZE + 5; $i += 1) {
$this->createScheduledTask();
}
expect(count(MockSimpleWorker::getScheduledTasks()))->equals(MockSimpleWorker::TASK_BATCH_SIZE);
@ -82,14 +82,14 @@ class SimpleWorkerTest extends \MailPoetTest {
}
function testItCanGetBatchOfRunningTasks() {
for($i = 0; $i < MockSimpleWorker::TASK_BATCH_SIZE + 5; $i += 1) {
for ($i = 0; $i < MockSimpleWorker::TASK_BATCH_SIZE + 5; $i += 1) {
$this->createRunningTask();
}
expect(count(MockSimpleWorker::getRunningTasks()))->equals(MockSimpleWorker::TASK_BATCH_SIZE);
}
function testItCanGetBatchOfCompletedTasks() {
for($i = 0; $i < MockSimpleWorker::TASK_BATCH_SIZE + 5; $i += 1) {
for ($i = 0; $i < MockSimpleWorker::TASK_BATCH_SIZE + 5; $i += 1) {
$this->createCompletedTask();
}
expect(count(MockSimpleWorker::getCompletedTasks()))->equals(MockSimpleWorker::TASK_BATCH_SIZE);

2
tests/integration/Models/NewsletterTemplateTest.php
View File

@ -71,7 +71,7 @@ class NewsletterTemplateTest extends \MailPoetTest {
function testItCanCleanRecentlySent() {
$total = NewsletterTemplate::RECENTLY_SENT_COUNT + 5;
for($i = 0; $i < $total; $i++) {
for ($i = 0; $i < $total; $i++) {
NewsletterTemplate::createOrUpdate(array(
'name' => 'Testing template ' . $i,
'body' => '{content: {}, globalStyles: {}}',

30
tests/integration/Models/NewsletterTest.php
View File

@ -299,7 +299,7 @@ class NewsletterTest extends \MailPoetTest {
);
$newsletters = array();
$sending_queues[] = array();
for($i = 0; $i < count($types); $i++) {
for ($i = 0; $i < count($types); $i++) {
$newsletters[$i] = Newsletter::createOrUpdate(
array(
'subject' => 'My Standard Newsletter',
@ -342,7 +342,7 @@ class NewsletterTest extends \MailPoetTest {
);
$newsletters = array();
$sending_queues[] = array();
for($i = 0; $i < count($types); $i++) {
for ($i = 0; $i < count($types); $i++) {
$newsletters[$i] = Newsletter::createOrUpdate(
array(
'subject' => 'My Standard Newsletter',
@ -416,7 +416,7 @@ class NewsletterTest extends \MailPoetTest {
);
$newsletters = array();
for($i = 0; $i < count($statuses); $i++) {
for ($i = 0; $i < count($statuses); $i++) {
$newsletters[$i] = Newsletter::createOrUpdate(
array(
'subject' => 'Test',
@ -440,7 +440,7 @@ class NewsletterTest extends \MailPoetTest {
$newsletter = $this->newsletter;
// create multiple sending queues
for($i = 1; $i <= 5; $i++) {
for ($i = 1; $i <= 5; $i++) {
$sending_queue = SendingTask::create();
$sending_queue->newsletter_id = $newsletter->id;
$sending_queue->save();
@ -461,7 +461,7 @@ class NewsletterTest extends \MailPoetTest {
function testItDeletesChildrenSegmentAndQueueAssociationsWhenParentNewsletterIsDeleted() {
$parent_newsletter = $this->newsletter;
// create multiple children (post notification history) newsletters and sending queues
for($i = 1; $i <= 5; $i++) {
for ($i = 1; $i <= 5; $i++) {
$newsletter = Newsletter::createOrUpdate(
array(
'subject' => 'test',
@ -494,7 +494,7 @@ class NewsletterTest extends \MailPoetTest {
function testItTrashesQueueAssociationsWhenNewsletterIsTrashed() {
// create multiple sending queues
$newsletter = $this->newsletter;
for($i = 1; $i <= 5; $i++) {
for ($i = 1; $i <= 5; $i++) {
$sending_queue = SendingTask::create();
$sending_queue->newsletter_id = $newsletter->id;
$sending_queue->save();
@ -510,7 +510,7 @@ class NewsletterTest extends \MailPoetTest {
function testItTrashesChildrenQueueAssociationsWhenParentNewsletterIsTrashed() {
$parent_newsletter = $this->newsletter;
// create multiple children (post notification history) newsletters and sending queues
for($i = 1; $i <= 5; $i++) {
for ($i = 1; $i <= 5; $i++) {
$newsletter = Newsletter::createOrUpdate(
array(
'subject' => 'test',
@ -536,7 +536,7 @@ class NewsletterTest extends \MailPoetTest {
function testItRestoresTrashedQueueAssociationsWhenNewsletterIsRestored() {
// create multiple sending queues
$newsletter = $this->newsletter;
for($i = 1; $i <= 5; $i++) {
for ($i = 1; $i <= 5; $i++) {
$sending_queue = SendingTask::create();
$sending_queue->newsletter_id = $newsletter->id;
$sending_queue->deleted_at = date('Y-m-d H:i:s');
@ -560,7 +560,7 @@ class NewsletterTest extends \MailPoetTest {
$parent_sending_queue->save();
// create multiple children (post notification history) newsletters and sending queues
for($i = 1; $i <= 5; $i++) {
for ($i = 1; $i <= 5; $i++) {
$newsletter = Newsletter::createOrUpdate(
array(
'subject' => 'test',
@ -587,7 +587,7 @@ class NewsletterTest extends \MailPoetTest {
function testItTrashesAllQueueAssociationsWhenNewslettersAreBulkTrashed() {
// create multiple newsletters and sending queues
for($i = 1; $i <= 5; $i++) {
for ($i = 1; $i <= 5; $i++) {
$newsletter = Newsletter::createOrUpdate(
array(
'subject' => 'test',
@ -610,7 +610,7 @@ class NewsletterTest extends \MailPoetTest {
function testItTrashesAllChildrenQueueAssociationsWhenParentNewslettersAreBulkTrashed() {
// create multiple children (post notification history) newsletters and sending queues
for($i = 1; $i <= 5; $i++) {
for ($i = 1; $i <= 5; $i++) {
$newsletter = Newsletter::createOrUpdate(
array(
'subject' => 'test',
@ -634,7 +634,7 @@ class NewsletterTest extends \MailPoetTest {
function testItBulkRestoresTrashedQueueAssociationsWhenNewslettersAreBulkRestored() {
// create multiple newsletters and sending queues
for($i = 1; $i <= 5; $i++) {
for ($i = 1; $i <= 5; $i++) {
$newsletter = Newsletter::createOrUpdate(
array(
'subject' => 'test',
@ -659,7 +659,7 @@ class NewsletterTest extends \MailPoetTest {
function testItBulkRestoresTrashedChildrenQueueAssociationsWhenParentNewslettersAreBulkRestored() {
// create multiple children (post notification history) newsletters and sending queues
for($i = 1; $i <= 5; $i++) {
for ($i = 1; $i <= 5; $i++) {
$newsletter = Newsletter::createOrUpdate(
array(
'subject' => 'test',
@ -685,7 +685,7 @@ class NewsletterTest extends \MailPoetTest {
function testItBulkDeletesSegmentAndQueueAssociationsWhenNewslettersAreBulkDeleted() {
// create multiple newsletters, sending queues and newsletter segments
for($i = 1; $i <= 5; $i++) {
for ($i = 1; $i <= 5; $i++) {
$newsletter = Newsletter::createOrUpdate(
array(
'subject' => 'test',
@ -716,7 +716,7 @@ class NewsletterTest extends \MailPoetTest {
function testItBulkDeletesChildrenSegmentAndQueueAssociationsWhenParentNewslettersAreBulkDeleted() {
$this->_after();
// create multiple children (post notification history) newsletters, sending queues and newsletter segments
for($i = 1; $i <= 5; $i++) {
for ($i = 1; $i <= 5; $i++) {
$newsletter = Newsletter::createOrUpdate(
array(
'subject' => 'test',

2
tests/integration/Models/SubscriberTest.php
View File

@ -973,7 +973,7 @@ class SubscriberTest extends \MailPoetTest {
// create 3 subscribers, segments and subscriber-segment relations
$prepare_data = function() {
$this->_after();
for($i = 1; $i <= 3; $i++) {
for ($i = 1; $i <= 3; $i++) {
$subscriber[$i] = Subscriber::create();
$subscriber[$i]->status = Subscriber::STATUS_SUBSCRIBED;
$subscriber[$i]->email = $i . '@test.com';

2
tests/integration/Statistics/Track/OpensTest.php
View File

@ -77,7 +77,7 @@ class OpensTest extends \MailPoetTest {
$opens = Stub::make($this->opens, array(
'returnResponse' => null
), $this);
for($count = 0; $count <= 2; $count++) {
for ($count = 0; $count <= 2; $count++) {
$opens->track($this->track_data);
}
expect(count(StatisticsOpens::findMany()))->equals(1);

2
tests/integration/Statistics/Track/UnsubscribesTest.php
View File

@ -42,7 +42,7 @@ class UnsubscribesTest extends \MailPoetTest {
}
function testItDoesNotTrackRepeatedUnsubscribeEvents() {
for($count = 0; $count <= 2; $count++) {
for ($count = 0; $count <= 2; $count++) {
$this->unsubscribes->track(
$this->newsletter->id,
$this->subscriber->id,

4
tests/integration/Subscribers/ConfirmationEmailMailerTest.php
View File

@ -86,7 +86,7 @@ class ConfirmationEmailMailerTest extends \MailPoetTest {
], $this);
$sender = new ConfirmationEmailMailer($mailer);
for($i = 0; $i < $sender::MAX_CONFIRMATION_EMAILS; $i++) {
for ($i = 0; $i < $sender::MAX_CONFIRMATION_EMAILS; $i++) {
expect($sender->sendConfirmationEmail($subscriber))->equals(true);
}
expect($sender->sendConfirmationEmail($subscriber))->equals(false);
@ -109,7 +109,7 @@ class ConfirmationEmailMailerTest extends \MailPoetTest {
], $this);
$sender = new ConfirmationEmailMailer($mailer);
for($i = 0; $i < $sender::MAX_CONFIRMATION_EMAILS; $i++) {
for ($i = 0; $i < $sender::MAX_CONFIRMATION_EMAILS; $i++) {
expect($sender->sendConfirmationEmail($subscriber))->equals(true);
}
expect($sender->sendConfirmationEmail($subscriber))->equals(true);

2
tests/integration/Subscription/ThrottlingTest.php
View File

@ -11,7 +11,7 @@ class ThrottlingTest extends \MailPoetTest {
$_SERVER['REMOTE_ADDR'] = '127.0.0.1';
expect(Throttling::throttle())->equals(false);
expect(Throttling::throttle())->equals(60);
for($i = 1; $i <= 10; $i++) {
for ($i = 1; $i <= 10; $i++) {
$ip = SubscriberIP::create();
$ip->ip = '127.0.0.1';
$ip->created_at = Carbon::now()->subMinutes($i);

4
tests/integration/Tasks/SendingTest.php
View File

@ -140,7 +140,7 @@ class SendingTest extends \MailPoetTest {
function testItGetsBatchOfScheduledQueues() {
$this->_after();
$amount = 5;
for($i = 0; $i < $amount + 3; $i += 1) {
for ($i = 0; $i < $amount + 3; $i += 1) {
$this->createNewSendingTask(['status' => ScheduledTask::STATUS_SCHEDULED]);
}
expect(SendingTask::getScheduledQueues($amount))->count($amount);
@ -171,7 +171,7 @@ class SendingTest extends \MailPoetTest {
function testItGetsBatchOfRunningQueues() {
$this->_after();
$amount = 5;
for($i = 0; $i < $amount + 3; $i += 1) {
for ($i = 0; $i < $amount + 3; $i += 1) {
$this->createNewSendingTask(['status' => null]);
}
expect(SendingTask::getRunningQueues($amount))->count($amount);

2
tests/integration/Tasks/Subscribers/BatchIteratorTest.php
View File

@ -10,7 +10,7 @@ class BatchIteratorTest extends \MailPoetTest {
$this->task_id = 123; // random ID
$this->batch_size = 2;
$this->subscriber_count = 10;
for($i = 0; $i < $this->subscriber_count; $i++) {
for ($i = 0; $i < $this->subscriber_count; $i++) {
ScheduledTaskSubscriber::createOrUpdate(array(
'task_id' => $this->task_id,
'subscriber_id' => $i + 1,